From: Denis Kenzior <denkenz@gmail.com>
To: iwd@lists.01.org
Subject: Re: [PATCH 01/16] hwsim: return radio ID on create
Date: Thu, 27 Aug 2020 15:08:35 -0500 [thread overview]
Message-ID: <d4772e1e-cf43-0d33-4d0b-3aa8fa468fca@gmail.com> (raw)
In-Reply-To: <20200827173229.26466-1-prestwoj@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 964 bytes --]
Hi James,
On 8/27/20 12:32 PM, James Prestwood wrote:
> Hwsim was relying on some internal behavior of mac80211_hwsim where new
> radios are created with ID's starting at zero and incremented. While
> this is a reasonable assumption its better to obtain the actual radio
> ID since mac80211_hwsim returns it in the radio creation callback.
>
> Now hwsim will return the radio ID when creating radios. Negative returns
> are still errors, but any value >= 0 indicates the radio ID of the newly
> created radio.
Ah, now I see what you meant by exit code. Sorry I should have caught this earlier.
So the problem is that UNIX doesn't really understand negative exit codes. exit
code of 0 is a success and anything else is a failure.
I think you will get people screaming obscenities if they try to use hwsim in a
script...
> ---
> tools/hwsim.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
Regards,
-Denis
next prev parent reply other threads:[~2020-08-27 20:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 17:32 [PATCH 01/16] hwsim: return radio ID on create James Prestwood
2020-08-27 17:32 ` [PATCH 02/16] auto-t: prepare autotests for test-runner re-write James Prestwood
2020-08-27 17:32 ` [PATCH 03/16] auto-t: introduce pure python " James Prestwood
2020-08-27 17:32 ` [PATCH 04/16] auto-t: hostapd.py: update to work with test-runner rewrite James Prestwood
2020-08-27 17:32 ` [PATCH 05/16] auto-t: testutil.py: " James Prestwood
2020-08-27 17:32 ` [PATCH 06/16] auto-t: ofono.py: fix timeout cleanup and wait for service James Prestwood
2020-08-27 17:32 ` [PATCH 07/16] auto-t: iwd.py: update to work with test-runner rewrite James Prestwood
2020-08-27 17:32 ` [PATCH 08/16] auto-t: iwd.py: fix multiple timeout cleanup issues James Prestwood
2020-08-27 17:32 ` [PATCH 09/16] auto-t: remove wiphy.py James Prestwood
2020-08-27 17:32 ` [PATCH 10/16] auto-t: fix hidden network test James Prestwood
2020-08-27 17:32 ` [PATCH 11/16] auto-t: fix testSAE autoconnect_test.py James Prestwood
2020-08-27 17:32 ` [PATCH 12/16] auto-t: skip ofono tests if ofonod isn't running James Prestwood
2020-08-27 17:32 ` [PATCH 13/16] auto-t: replace hard-coded interfaces James Prestwood
2020-08-27 17:32 ` [PATCH 14/16] auto-t: remove device.wait_for_connected James Prestwood
2020-08-27 17:32 ` [PATCH 15/16] tools: post test-runner rewrite cleanup James Prestwood
2020-08-27 17:32 ` [PATCH 16/16] doc: update test runner docs James Prestwood
2020-08-27 20:08 ` Denis Kenzior [this message]
2020-08-27 20:21 ` [PATCH 01/16] hwsim: return radio ID on create James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4772e1e-cf43-0d33-4d0b-3aa8fa468fca@gmail.com \
--to=denkenz@gmail.com \
--cc=iwd@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox