public inbox for iwd@lists.linux.dev
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: iwd@lists.linux.dev
Subject: Re: [PATCH] wiphy: Remove basename() use
Date: Thu, 22 Feb 2024 09:27:02 -0600	[thread overview]
Message-ID: <d5015f0b-fb62-4ebd-a088-a39a4f9f4171@gmail.com> (raw)
In-Reply-To: <20240214205523.1109159-1-denkenz@gmail.com>

On 2/14/24 14:55, Denis Kenzior wrote:
> basename use is considered harmful.  There are two versions of
> basename (see man 3 basename for details).  The more intuitive version,
> which is currently being used inside wiphy.c, is not supported by musl
> libc implementation.  Use of the libgen version is not preferred, so
> drop use of basename entirely.  Since wiphy.c is the only call site of
> basename() inside iwd, open code the required logic.
> ---
>   src/wiphy.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 

Applied.



      reply	other threads:[~2024-02-22 15:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-14 20:55 [PATCH] wiphy: Remove basename() use Denis Kenzior
2024-02-22 15:27 ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5015f0b-fb62-4ebd-a088-a39a4f9f4171@gmail.com \
    --to=denkenz@gmail.com \
    --cc=iwd@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox