Re: [PATCH] sae: support default group for H2E

[Denis Kenzior <denkenz@gmail.com>]

Hi James,

On 8/12/24 12:16 PM, James Prestwood wrote:
> This was seemingly trivial at face value but doing so ended up
> pointing out a bug with how group_retry is set when forcing
> the default group. Since group_retry is initialized to -1 the
> increment in the force_default_group block results in it being
> set to zero, which is actually group 20, not 19. This did not
> matter for hunt and peck, but H2E actually uses the retry value
> to index its pre-generated points which then breaks SAE if
> forcing the default group with H2E.
> 
> To handle H2E and force_default_group, the group selection
> logic will always begin iterating the group array regardless of
> SAE type.
> ---
>   src/sae.c | 41 ++++++++++++++++++-----------------------
>   1 file changed, 18 insertions(+), 23 deletions(-)

Applied.  Do we have test for H2E & force behavior?

Regards,
-Denis