Re: [PATCH v2] test-runner: fix duplicate process output

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 865 bytes --]

Hi James,

On 3/2/21 10:30 AM, James Prestwood wrote:
> Process output was being duplicated when -v was used. This was
> due to both stderr and stdout being appended to the write_fd list
> as well as stderr being set to stdout in the Popen call.
> 
> To fix this only stdout should be appended to the write_fd list,
> but then there comes a problem with closing the streams. stdout
> cannot be closed, so instead it is special cased. A new
> verbose boolean was added to Process which, if True, will
> cause any output to be written to stdout explicitly.
> ---
>   tools/test-runner | 14 ++++++++++----
>   1 file changed, 10 insertions(+), 4 deletions(-)
> 
> v2:
>   * Added check for self.verbose so long running
>     processes get an IO watch and can actually
>     print to the console with -v.
> 

Applied, thanks.

Regards,
-Denis