Wireless Daemon for Linux
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: iwd@lists.01.org
Subject: Re: [PATCH 2/7] ip-pool: Add subnet address selection logic
Date: Wed, 26 May 2021 15:06:55 -0500	[thread overview]
Message-ID: <e07fe248-5353-eeff-d766-36487e2c34f4@gmail.com> (raw)
In-Reply-To: <c119acaf-d675-fca9-62a4-87fcefca4000@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 522 bytes --]

Hi Andrew,

>> +int ip_pool_select_addr4(const char **addr_str_list, uint8_t prefix,
>> +                struct netdev *netdev, uint32_t *out_addr);
>>   const struct ip_pool_addr4_record *ip_pool_get_addr4(struct netdev *netdev);
>>
> 

Oh, and another thing.  Can this just return us an l_rtnl_address? The 
address/prefix is known and that is basically all you need for the 
l_rtnl_address object. That way it can be used directly in l_rtnl_ifaddr_add / 
delete functions.

Regards,
-Denis

  reply	other threads:[~2021-05-26 20:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25 12:55 [PATCH 1/7] ip-pool: Track IPv4 addresses in use Andrew Zaborowski
2021-05-25 12:55 ` [PATCH 2/7] ip-pool: Add subnet address selection logic Andrew Zaborowski
2021-05-26 19:56   ` Denis Kenzior
2021-05-26 20:06     ` Denis Kenzior [this message]
2021-05-26 21:50     ` Andrew Zaborowski
2021-05-25 12:55 ` [PATCH 3/7] ap: Refactor DHCP settings loading Andrew Zaborowski
2021-05-25 12:55 ` [PATCH 4/7] ap: Refactor global address pool loading Andrew Zaborowski
2021-05-25 12:55 ` [PATCH 5/7] ap: Send a specific error message on async AP start failure Andrew Zaborowski
2021-05-25 12:55 ` [PATCH 6/7] autotests: Update APRanges usage in testAP Andrew Zaborowski
2021-05-25 12:55 ` [PATCH 7/7] doc: Update AP settings in iwd.ap(5) and iwd.config(5) Andrew Zaborowski
2021-05-26 19:43 ` [PATCH 1/7] ip-pool: Track IPv4 addresses in use Denis Kenzior
2021-05-26 21:37   ` Andrew Zaborowski
2021-05-26 21:56     ` Denis Kenzior
2021-05-26 22:02       ` Denis Kenzior
2021-05-26 22:36       ` Andrew Zaborowski
2021-05-26 22:55         ` Denis Kenzior
2021-05-26 23:26           ` Andrew Zaborowski
2021-05-26 23:33             ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e07fe248-5353-eeff-d766-36487e2c34f4@gmail.com \
    --to=denkenz@gmail.com \
    --cc=iwd@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox