Re: [PATCH v2 1/4] test-runner: Support running hostapd in namespaces

[James Prestwood <prestwoj@gmail.com>]

Hi Andrew,
> > >  class Radio:
> > >         def __init__(self, name):
> > > @@ -75,11 +78,16 @@ class Radio:
> > >                 # hostapd will reset this if this radio is used
> > > by it
> > >                 self.use = 'iwd'
> > >                 self.interface = None
> > > +               self.ns = None
> > > 
> > >         def __del__(self):
> > >                 print("Removing radio %s" % self.name)
> > >                 self.interface = None
> > > 
> > > +       def set_namespace(self, ns):
> > > +               self.ns = ns
> > > +               Process(['iw', 'phy', self.name, 'set', 'netns',
> > > 'name', ns.name]).wait()
> > > +
> > >         def create_interface(self, config, use):
> > >                 global intf_id
> > > 
> > > @@ -87,19 +95,21 @@ class Radio:
> > > 
> > >                 intf_id += 1
> > > 
> > > -               self.interface = Interface(ifname, config)
> > > +               self.interface = Interface(ifname, config,
> > > ns=self.ns)
> > >                 self.use = use
> > > 
> > >                 Process(['iw', 'phy', self.name, 'interface',
> > > 'add',
> > > ifname,
> > > -                               'type', 'managed']).wait()
> > > +                               'type', 'managed'],
> > > namespace=self.ns.name if self.ns else None).wait()
> > > 
> > >                 return self.interface
> > 
> > Since create_interface() is the only function that needs the
> > namespace
> > couldn't we remove set_namespace entirely and just pass the
> > namespace
> > name into create_interface?
> 
> So set_namespace() also moves the radio to the right namespace.  We
> need this for radios used by both hostapd and IWD, where we don't use
> create_interface().
> 
> I also think it's nice if you can obtain the namespace reference from
> `radio.ns` or `interface.ns`, say, in autotests/util/*.py code or
> elsewhere.


Are there situations where hostapd and IWD share a radio?

But I agree, its nice knowing what namespace a radio/interface belongs
to.

> 
> > 
> > > +       def get_hapd_instance(self, config=None):
> > > +               instances = [i for hapd in self.hostapd for i in
> > > hapd.instances]
> > > +
> > > +               if config is None:
> > > +                       return instances[0]
> > > +
> > > +               for hapd in instances:
> > > +                       if hapd.config == config:
> > > +                               return hapd
> > > +
> > 
> > Looks like this got carried over from that dropped patch?
> 
> I use this in autotests/util/hostapd.py (patch 2/4) since ctx.hostapd
> is now a list and to override the [] operator you'd need to subclass
> the list and overall it's simpler this way.


Sorry, I was confusing this with the HostapdCLI stuff. Nevermind.

> 
> Thanks for the review,
> Best regards