Wireless Daemon for Linux
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: James Prestwood <prestwoj@gmail.com>, iwd@lists.linux.dev
Subject: Re: [PATCH 1/3] station: handle ROAMING state in disconnect event
Date: Wed, 28 Sep 2022 12:34:41 -0500	[thread overview]
Message-ID: <fd7c11cd-3389-dcf3-e8d7-d4f29ca6b250@gmail.com> (raw)
In-Reply-To: <20220927231549.310800-1-prestwoj@gmail.com>

Hi James,

On 9/27/22 18:15, James Prestwood wrote:
> This both adds proper handling to the new roaming logic and fixes
> a potential bug with firmware roams.
> 
> The new way roaming works doesn't use a connect callback. This
> means that any disconnect event or call to netdev_connect_failed
> will result in the event handler being called, where before the
> connect callback would. This means we need to handle the ROAMING
> state in the station disconnect event so IWD properly disassociates
> and station goes out of ROAMING.
> 
> With firmware roams netdev gets an event which transitions station
> into ROAMING. Then netdev issues GET_SCAN. During this time a
> disconnect event could come in which would end up in
> station_disconnect_event since there is no connect callback. This
> needs to be handled the same and let IWD transition out of the
> ROAMING state.
> ---
>   src/station.c | 1 +
>   1 file changed, 1 insertion(+)
> 

All applied, thanks.

Regards,
-Denis


      parent reply	other threads:[~2022-09-28 17:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-27 23:15 [PATCH 1/3] station: handle ROAMING state in disconnect event James Prestwood
2022-09-27 23:15 ` [PATCH 2/3] ft: clear ft_info inside offchannel destroy James Prestwood
2022-09-27 23:15 ` [PATCH 3/3] ft: fix ft_associate to verify if authentication succeeded James Prestwood
2022-09-28 17:34 ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd7c11cd-3389-dcf3-e8d7-d4f29ca6b250@gmail.com \
    --to=denkenz@gmail.com \
    --cc=iwd@lists.linux.dev \
    --cc=prestwoj@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox