From: Felix Janda <felix.janda@posteo.de>
To: kbd@lists.altlinux.org
Subject: [kbd] [PATCH 0/4] Some fixes for compilation with musl
Date: Thu, 4 Dec 2014 20:56:17 +0100 [thread overview]
Message-ID: <20141204195617.GA5691@euler> (raw)
Patch 2-4 add missing headers and fix the compilation with
musl libc of the respective files.
Patch 1 is an unrelated encoding fix.
With these patches, kbd still does not compile with musl
because musl does not provide the non-standard error.h and
error(). Would it be ok to replace all invocations with
similar invocations of perror() and fprintf()?
For example in main() of kbdinfo.c, change
if (ioctl(fd, KDGETMODE, &mode) == -1)
error(EXIT_FAILURE, errno, "ioctl");
to
if (ioctl(fd, KDGETMODE, &mode) == -1) {
perror("ioctl");
return EXIT_FAILURE;
}
This changes the output slightly since error() also prints
the program name. Since however a mixture of error(), perror()
and fprintf() is used in the source anyway, the change
would increase the consistency of the output.
Felix Janda (4):
src/kbdrate: iconv from iso-8859-2 to utf8
libkeymap: include <sys/types.h> for u_short
kbdrate.c, openvt.c: include <fcntl.h> for open()
openvt.c: include <limits.h> for NAME_MAX
src/kbdrate.c | 3 ++-
src/libkeymap/dump.c | 1 +
src/libkeymap/kmap.c | 1 +
src/libkeymap/summary.c | 1 +
src/openvt.c | 2 ++
5 files changed, 7 insertions(+), 1 deletion(-)
--
2.0.4
reply other threads:[~2014-12-04 19:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141204195617.GA5691@euler \
--to=felix.janda@posteo.de \
--cc=kbd@lists.altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox