* [kbd] [PATCH] Fix "compose as usual" for Unicode diacritics
@ 2010-10-13 15:07 Michael Schutte
2010-10-16 20:21 ` Alexey Gladkov
2010-10-18 7:13 ` Alexey Gladkov
0 siblings, 2 replies; 3+ messages in thread
From: Michael Schutte @ 2010-10-13 15:07 UTC (permalink / raw)
To: kbd
struct ccc in compose_as_usua[() uses three char members of unspecified
signedness; in case the compiler decides that they should be signed,
negative integers will end up in the accent table for c3 > 127.
Avoid the problem by explicitly using unsigned chars.
Signed-off-by: Michael Schutte <michi@uiae.at>
---
src/loadkeys.y | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/loadkeys.y b/src/loadkeys.y
index c8bb7cc..cc7e2ab 100644
--- a/src/loadkeys.y
+++ b/src/loadkeys.y
@@ -1181,7 +1181,7 @@ compose_as_usual(char *charset) {
exit(1);
} else {
struct ccc {
- char c1, c2, c3;
+ unsigned char c1, c2, c3;
} def_latin1_composes[68] = {
{ '`', 'A', 0300 }, { '`', 'a', 0340 },
{ '\'', 'A', 0301 }, { '\'', 'a', 0341 },
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [kbd] [PATCH] Fix "compose as usual" for Unicode diacritics
2010-10-13 15:07 [kbd] [PATCH] Fix "compose as usual" for Unicode diacritics Michael Schutte
@ 2010-10-16 20:21 ` Alexey Gladkov
2010-10-18 7:13 ` Alexey Gladkov
1 sibling, 0 replies; 3+ messages in thread
From: Alexey Gladkov @ 2010-10-16 20:21 UTC (permalink / raw)
To: kbd
13.10.2010 19:07, Michael Schutte wrote:
> struct ccc in compose_as_usua[() uses three char members of unspecified
> signedness; in case the compiler decides that they should be signed,
> negative integers will end up in the accent table for c3 > 127.
>
> Avoid the problem by explicitly using unsigned chars.
>
> Signed-off-by: Michael Schutte <michi@uiae.at>
> ---
> src/loadkeys.y | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/loadkeys.y b/src/loadkeys.y
> index c8bb7cc..cc7e2ab 100644
> --- a/src/loadkeys.y
> +++ b/src/loadkeys.y
> @@ -1181,7 +1181,7 @@ compose_as_usual(char *charset) {
> exit(1);
> } else {
> struct ccc {
> - char c1, c2, c3;
> + unsigned char c1, c2, c3;
> } def_latin1_composes[68] = {
> { '`', 'A', 0300 }, { '`', 'a', 0340 },
> { '\'', 'A', 0301 }, { '\'', 'a', 0341 },
Indeed.
I tried to add the -Wconversion and was horrified (about 368 warnings).
--
Rgrds, legion
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [kbd] [PATCH] Fix "compose as usual" for Unicode diacritics
2010-10-13 15:07 [kbd] [PATCH] Fix "compose as usual" for Unicode diacritics Michael Schutte
2010-10-16 20:21 ` Alexey Gladkov
@ 2010-10-18 7:13 ` Alexey Gladkov
1 sibling, 0 replies; 3+ messages in thread
From: Alexey Gladkov @ 2010-10-18 7:13 UTC (permalink / raw)
To: kbd
13.10.2010 19:07, Michael Schutte wrote:
> struct ccc in compose_as_usua[() uses three char members of unspecified
> signedness; in case the compiler decides that they should be signed,
> negative integers will end up in the accent table for c3 > 127.
>
> Avoid the problem by explicitly using unsigned chars.
>
> Signed-off-by: Michael Schutte <michi@uiae.at>
Applied, thanks!
--
Rgrds, legion
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-18 7:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-13 15:07 [kbd] [PATCH] Fix "compose as usual" for Unicode diacritics Michael Schutte
2010-10-16 20:21 ` Alexey Gladkov
2010-10-18 7:13 ` Alexey Gladkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox