From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B876F30CD86 for ; Fri, 7 Nov 2025 23:20:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762557610; cv=none; b=RnAf8m0hh5C1Ypd6pZpY+2dik2i3usXppL7hMgWSqj3B81thXfr1L9qSCF/pz7U5N5u3UbD9+gmY8wWqLQDztU2hwrEcevPrzHgrbRxHoLb/Fc+H426CgcKBfKb1LRcOgCcUGGI+kkT76W2jUU7WgGn9qdkek+b/f3qGnYDkC+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762557610; c=relaxed/simple; bh=fqBY4YmYfyv1VRebLLWLO+CJngi5jsTycRx8uuSNs2M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BLE+OoDVufn+7R3++1VgdJCaPAt0fbvY7zXk5pFVPJGGlgZf3R+z4gG29AgjDXPRhypcKcPrsByONxgWMe5fK4IjQ5kemJ/Sgx3ai/Deihs0Ga5EKpZZX7oUWWzLaDnh/JCbnw73Uor9c6mBuKeyIK8TmWgwzNQAQUxuQBSvY2k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EiAym8jw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EiAym8jw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64607C113D0; Fri, 7 Nov 2025 23:20:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762557609; bh=fqBY4YmYfyv1VRebLLWLO+CJngi5jsTycRx8uuSNs2M=; h=Date:Reply-To:Subject:To:Cc:References:From:In-Reply-To:From; b=EiAym8jwqOh6YSsPEtntc3gVcohEo9AFfrTl0Ht3DyiKkW0VmNVJrnz7roq15SfxI BbeB61Fp6g51zsXj2rueseDysavfgX/bnmT+LIa2spE/Qi/ldAUhHLNe1XtrWxV0Zw 5z8j4NN/aIYEAfEAvohG+HHVDOuP9+sBN3z2/vr5LKxhghQXx7NbTdlC7KLpSc8BU9 h/DqKbGmuCfhH5Sv9Qd0OFoOmwKs/bJ+EcIvWUAXQGljg7jve6SLKbwOQVTmZJ+KUQ oVhRQ+jQAw/bQ+PwusM5Z6LI/+HLYC+7uXXC12S1sytM1WhkFD1UFdVaht6qpP6CvC 4DNeoQdS3U1DA== Message-ID: <0551827c-a0bd-4589-b9e4-073aa545ccb0@kernel.org> Date: Sat, 8 Nov 2025 00:20:05 +0100 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Daniel Gomez Subject: Re: [PATCH v2 09/15] bootlinux: fix os detection for 9p build dependency installation To: Chuck Lever , Luis Chamberlain Cc: kdevops@lists.linux.dev, Daniel Gomez References: <20251029-fedora-on-debian-v2-0-ddc6e5bebc15@samsung.com> <20251029-fedora-on-debian-v2-9-ddc6e5bebc15@samsung.com> <7a126e42-a65c-4020-b7b4-3e8c784be593@oracle.com> <9657ff48-8cc0-4ce6-b52c-ef1ab40c7a74@kernel.org> <0439acaf-b96b-4553-9a3a-59cd7134e50b@oracle.com> <52e65c62-70eb-47da-b0e2-c92e5c514cbd@kernel.org> Content-Language: en-US From: Daniel Gomez Organization: kernel.org In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 07/11/2025 21.53, Chuck Lever wrote: > On 11/7/25 3:47 PM, Daniel Gomez wrote: >> >> >> On 07/11/2025 21.17, Chuck Lever wrote: >>> On 11/7/25 3:00 PM, Daniel Gomez wrote: >>>> On 07/11/2025 20.22, Chuck Lever wrote: >>>>> On 10/29/25 8:40 AM, Daniel Gomez wrote: >>>>>> From: Daniel Gomez >>>>>> >>>>>> Dependency installation for 9P builds was checking ansible_os_family, >>>>>> which references the target guest's OS instead of the control host where >>>>>> packages are actually installed. This caused incorrect packages to be >>>>>> installed when building Fedora guests on Debian hosts. >>>>>> >>>>>> Replace ansible_os_family checks with Kconfig distro variables >>>>>> (distro_debian_based, distro_fedora, etc.) which correctly detect >>>>>> the control host's distribution. Add fallback defaults to ensure the >>>>>> variables are always defined for standalone role usage. >>>>>> >>>>>> Generated-by: Claude AI >>>>>> Suggested-by: Chuck Lever >>>>> >>>>> Hrm. I might not have understood the whole picture. >>>>> >>>>> Yes, distro_yada_based does pick the controller's OS version. >>>>> But so does ansible_os_family when the task is running on >>>>> localhost. >>>> >>>> Just a reminder that we control where tasks are deployed with --limit and/or >>>> hosts: field in bootlinux.yml. For this case, IIRC, the playbook was run for >>>> baseline:dev but tasks were "delegated_to" localhost. >>> >>> That's new since I did the "build kernel on a separate target node" >>> changes and the related clean-ups in the bootlinux playbook. Not a >>> finger-point, just saying we could have collided somewhere. >>> >>> >>>>> I just hit a problem with the "build linux on a separate >>>>> target node" configuration, where the target is running >>>>> Debian 11 and the controller is running Fedora 41. The >>>>> bootlinux install-deps/main.yml checks were coming to >>>>> the wrong conclusion. >>>> >>>> Can you share the output? And the --limit argument used in this case? >>>> FYI, I normally enable CONFIG_KDEVOPS_MAKE_VERBOSE=y) which prints: >>>> >>>> make bringup >>>> + make linux-clone >>>> ==> [guestfs/kdevops_nodes.yaml] >>>> + ansible-playbook playbooks/gen_nodes.yml --extra-vars=@./extra_vars.yaml >>>> ... >>>> ==> [linux-clone-9p] >>>> + ansible-playbook --limit localhost playbooks/bootlinux.yml >>>> '--extra-vars=target_linux_git=/mirror/linux.git ... >>>> ... >>> >>> Here's from my scroll-back buffer earlier this afternoon: >>> >>> TASK [install-rust-deps : Install Rust build dependencies] >>> ************************************************************************************* >>> included: >>> /home/cel/src/kdevops/buildbot-configs/playbooks/roles/install-rust-deps/tasks/install-deps/main.yml >>> for kernel-builder >>> >>> TASK [install-rust-deps : Install Rust build dependencies] >>> ************************************************************************************* >>> changed: [kernel-builder] >>> FAILED - RETRYING: [kernel-builder]: Install packages we care about (3 >>> retries left). >>> FAILED - RETRYING: [kernel-builder]: Install packages we care about (2 >>> retries left). >>> FAILED - RETRYING: [kernel-builder]: Install packages we care about (1 >>> retries left). >>> >>> TASK [bootlinux : Install packages we care about] >>> ********************************************************************************************** >>> task path: >>> /home/cel/src/kdevops/buildbot-configs/playbooks/roles/bootlinux/tasks/install-deps/redhat/main.yml:8 >>> fatal: [kernel-builder]: FAILED! => { >>> "ansible_facts": { >>> "pkg_mgr": "apt" >>> }, >>> "attempts": 3, >>> "changed": false >>> } >>> >>> MSG: >>> >>> ('Could not detect which major revision of dnf is in use, which is >>> required to determine module backend.', 'You should manually specify >>> use_backend to tell the module whether to use the dnf4 or dnf5 backend})') >>> >>> >>> As you can see, bootlinux is trying to install the redhat deps on >>> the target, but in fact the target is running Debian 11. This is >>> because the install-deps play is now looking at distro_yada_based >>> even though it is running on the target. >> >> I think we need to detect both cases based on the target selection >> (BOOTLINUX_TARGETS). Can you give this a try/check/review? >> >> For 9p targets (controller node, ie BOOTLINUX_9P), we keep the >> distro_yada_based. For builder targets (BOOTLINUX_BUILDER) we use the >> ansible_os_family: >> >> diff --git a/playbooks/roles/bootlinux/tasks/install-deps/main.yml b/playbooks/roles/bootlinux/tasks/install-deps/main.yml >> index 058f3926..88d2baad 100644 >> --- a/playbooks/roles/bootlinux/tasks/install-deps/main.yml >> +++ b/playbooks/roles/bootlinux/tasks/install-deps/main.yml >> @@ -1,15 +1,36 @@ >> --- >> -- name: Debian-specific setup >> +- name: Debian-specific setup (9p/controller node) >> ansible.builtin.import_tasks: debian/main.yml >> when: >> - distro_debian_based|bool >> + - bootlinux_9p|bool >> >> -- name: SuSE-specific setup >> +- name: Debian-specific setup (builder node) >> + ansible.builtin.import_tasks: debian/main.yml >> + when: >> + - bootlinux_builder|bool >> + - ansible_os_family == "Debian" >> + >> +- name: SuSE-specific setup (9p/controller node) >> ansible.builtin.import_tasks: suse/main.yml >> when: >> - distro_suse_based|bool >> + - bootlinux_9p|bool >> >> -- name: Red Hat-specific setup >> +- name: SuSE-specific setup (builder node) >> + ansible.builtin.import_tasks: suse/main.yml >> + when: >> + - bootlinux_builder|bool >> + - ansible_os_family == "Suse" >> + >> +- name: Red Hat-specific setup (controller node) >> ansible.builtin.import_tasks: redhat/main.yml >> when: >> - distro_redhat_based|bool >> + - bootlinux_9p|bool >> + >> +- name: Red Hat-specific setup (builder node) >> + ansible.builtin.import_tasks: redhat/main.yml >> + when: >> + - bootlinux_builder|bool >> + - ansible_os_family == "RedHat" >> >> IIUC, this should return the correct ansible_os_family value when builder target >> is selected because the task is executed on the guest with --limit baseline:dev. > Hi Daniel - > > None of these tasks will execute if bootlinux_targets == true, AFAICT. Sorry, I missed that target. I meant to add that condition too when we use ansible_os_family case. > > Why can't this work based on which host the install-deps tasks are > running on? That was the original design I had in mind, and seems > most Ansible-like. I can't replicate the issue. I think we can revert the patch. Here my tests: fedora: https://github.com/linux-kdevops/kdevops/actions/runs/19183690762 debian: https://github.com/linux-kdevops/kdevops/actions/runs/19183543710 > >