Re: [PATCH 4/6] NFSD: Implement NVMe storage for NFSD exports

[Chuck Lever <chuck.lever@oracle.com>]

On 12/10/24 10:42 PM, Luis Chamberlain wrote:
> On Tue, Dec 10, 2024 at 02:29:17PM -0500, cel@kernel.org wrote:
>> diff --git a/playbooks/roles/nfsd/tasks/main.yml b/playbooks/roles/nfsd/tasks/main.yml
>> index 63388f857627..c7c41e79714b 100644
>> --- a/playbooks/roles/nfsd/tasks/main.yml
>> +++ b/playbooks/roles/nfsd/tasks/main.yml
>> @@ -38,15 +38,34 @@
>>     when:
>>       - nfsd_export_storage_local|bool
>>   
>> -- name: Create a new LVM VG
>> -  become: yes
>> -  become_flags: 'su - -c'
>> -  become_method: sudo
>> +- name: Enumerate NVMe devices to provision as PVs
>> +  become: true
>> +  become_flags: "su - -c"
>> +  become_method: ansible.builtin.sudo
>> +  ansible.builtin.command:
>> +    cmd: "lsblk -np -o PATH,SERIAL"
>> +  register: lsblk_output
>> +  changed_when: false
>> +  when:
>> +    - nfsd_export_storage_nvme|bool
>> +
>> +- name: Build a list of NVMe devices to provision as PVs
>> +  ansible.builtin.set_fact:
>> +    nfsd_lvm_pvs: "{{ nfsd_lvm_pvs + [item | split() | first] }}"
>> +  loop: "{{ lsblk_output.stdout_lines }}"
>> +  when:
>> +    - nfsd_export_storage_nvme|bool
>> +    - '"AWS" in item'
> 
> I think you may want to add a new output yaml for when the provider is
> AWS so you get devops_terraform_provider_is_aws so you can just check
> for that here as an extra bool. That will ensure with more determinism
> that the bringup is on AWS.

Apologies for asking, but do you have a particular commit ID or file I
could use as an example?

-- 
Chuck Lever