[PATCH] bringup: fix the soft iWARP bringup

[PATCH] bringup: fix the soft iWARP bringup

[Jeff Layton]

It seemed like this worked for me at some point, but today it was
failing to start for me. In any case, removing the ACTION= filter seemed
to fix it for me.

Also, after reloading the udev rules, trigger them to be run so the
siw interface is immediately started.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 playbooks/roles/siw/tasks/main.yml         | 2 +-
 playbooks/roles/siw/templates/udev-rule.j2 | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/playbooks/roles/siw/tasks/main.yml b/playbooks/roles/siw/tasks/main.yml
index f6d3f56136ed..be5aeb70be2c 100644
--- a/playbooks/roles/siw/tasks/main.yml
+++ b/playbooks/roles/siw/tasks/main.yml
@@ -22,4 +22,4 @@
 - name: Force the target host to reload its udev ruleset
   become: yes
   become_method: sudo
-  ansible.builtin.command: "udevadm control --reload"
+  ansible.builtin.shell: "udevadm control --reload && udevadm trigger"
diff --git a/playbooks/roles/siw/templates/udev-rule.j2 b/playbooks/roles/siw/templates/udev-rule.j2
index 6fcaea6d1684..54f7beb6a764 100644
--- a/playbooks/roles/siw/templates/udev-rule.j2
+++ b/playbooks/roles/siw/templates/udev-rule.j2
@@ -1,2 +1,2 @@
-ACTION=="add", SUBSYSTEM=="net", KERNEL=="{{ ansible_default_ipv4.interface }}", \
+SUBSYSTEM=="net", KERNEL=="{{ ansible_default_ipv4.interface }}", \
    PROGRAM="/usr/sbin/rdma link add siw0 type siw netdev {{ ansible_default_ipv4.interface }}"
-- 
2.43.0

Re: [PATCH] bringup: fix the soft iWARP bringup

[Chuck Lever III]

> On Jan 26, 2024, at 11:56 AM, Jeff Layton <jlayton@kernel.org> wrote:
> 
> It seemed like this worked for me at some point, but today it was
> failing to start for me. In any case, removing the ACTION= filter seemed
> to fix it for me.

Fair enough!


> Also, after reloading the udev rules, trigger them to be run so the
> siw interface is immediately started.

Distributions generally don't enable siw.ko (although some might
start doing so). Does the trigger cause that step to fail on
distribution kernels? If so, maybe that should be in another
step with a "failed: false" attribute.


> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> playbooks/roles/siw/tasks/main.yml         | 2 +-
> playbooks/roles/siw/templates/udev-rule.j2 | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/playbooks/roles/siw/tasks/main.yml b/playbooks/roles/siw/tasks/main.yml
> index f6d3f56136ed..be5aeb70be2c 100644
> --- a/playbooks/roles/siw/tasks/main.yml
> +++ b/playbooks/roles/siw/tasks/main.yml
> @@ -22,4 +22,4 @@
> - name: Force the target host to reload its udev ruleset
>   become: yes
>   become_method: sudo
> -  ansible.builtin.command: "udevadm control --reload"
> +  ansible.builtin.shell: "udevadm control --reload && udevadm trigger"
> diff --git a/playbooks/roles/siw/templates/udev-rule.j2 b/playbooks/roles/siw/templates/udev-rule.j2
> index 6fcaea6d1684..54f7beb6a764 100644
> --- a/playbooks/roles/siw/templates/udev-rule.j2
> +++ b/playbooks/roles/siw/templates/udev-rule.j2
> @@ -1,2 +1,2 @@
> -ACTION=="add", SUBSYSTEM=="net", KERNEL=="{{ ansible_default_ipv4.interface }}", \
> +SUBSYSTEM=="net", KERNEL=="{{ ansible_default_ipv4.interface }}", \
>    PROGRAM="/usr/sbin/rdma link add siw0 type siw netdev {{ ansible_default_ipv4.interface }}"
> -- 
> 2.43.0
> 
> 

--
Chuck Lever