From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46B7616427 for ; Tue, 5 Mar 2024 18:00:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709661650; cv=none; b=K2/RNC3rMRvdCyh5YjKsvg8DjKsfHVHG16yo687aVxt4+RvMkq5FPlG5hz/bXdZ2qFswfblxLFtQEpVTK+29jwKvn3fBK0C2i15fs6LiAf++zIpsIALBq/bwIkUbvpp4kTt2YL74Aslv2cqef3ry8Mvgokwd6rw6LfmCE9FBRsI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709661650; c=relaxed/simple; bh=6IYRV/OrtUeodmnq0cxZa9TXupB5fbsLWUV2ysCNW+0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=H6ki9Bu61xZ2cagP9ybyLwcx6FWc+gTWhc2SV/ECYb8k3ij437hcgKBA5FwB3vH8vPLe1mgivjvlLCGynOrptVci7MOsH+MJHU3qB+9k4PxPVBFJH4a+ZzNvHs6x5Ncf2kv4qW42Ne6c17Q+Nz17nDROarK1mCCRLMjiF+3vezE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20230601.gappssmtp.com header.i=@cmpxchg-org.20230601.gappssmtp.com header.b=Ny9TAWjO; arc=none smtp.client-ip=209.85.219.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20230601.gappssmtp.com header.i=@cmpxchg-org.20230601.gappssmtp.com header.b="Ny9TAWjO" Received: by mail-yb1-f173.google.com with SMTP id 3f1490d57ef6-db4364ecd6aso6294252276.2 for ; Tue, 05 Mar 2024 10:00:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1709661646; x=1710266446; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Z5pJ9KeesQcbLNZPP2exaLZRRz+UmF7kq+th3jBpZqI=; b=Ny9TAWjOO0IFbNG660j1C0zfAWppLnf1vWCgagpj4JTJQrgjm9+wT5SIsnPsmXwn7z y/OtqaFl53RZySoR24D0rG6N2EFSWhIixxVtTPY8TUENLoy0CnGRftTnAkCz6gygAK8U tY34Q98IonLP+kShQmeJTsvqJpXIxvbfADmcyjEJZSMP/OM0tkSivexQe0YxK0SF5k9C OpkdLWBs96QeetSpt0y6kCBBT/VI0LNBK7/An2JVlU8IsYKaR6NkuFoSCfMkHPWaDtv9 Djrp9yqDvguRzmI0ZNdTGkkKPQfC5hppts+4v0BJ3b9AP+Htelv6Ff6GMkEd0lz+BR9C nnsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709661646; x=1710266446; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z5pJ9KeesQcbLNZPP2exaLZRRz+UmF7kq+th3jBpZqI=; b=SWXJ9cg8QGxYFlHgB85jYePF7F7cSCWXf//ByB1uLfrcylTafb//4+YLNQS8zU0Clw fWnSqCWG4AF8w+MalGObtO2F2Ai+Jttv7q6syY5VjZ4Hip8rGBlRQHNhIw9Fmur9LCIz cfeIIvKGDZ7+ezL/YrG0eZc0U53IMJXl0hI+lP5i8PdCaQvOW0vkWw+TK4nSh9c564dV h6jm9f5mEYyCkr2z+LLAV3BtZd8AdC70rLZNiMbw4O5KWh3E0zd6Vw0/DuA0RGzTR1Ly VFf9x3uqjlmeluHA5npWH8HZqX6muqOe8Yk8tGXihJsDybtkpZ0K+Fb/HpPOsNySGQIC rfGQ== X-Forwarded-Encrypted: i=1; AJvYcCVYkem9DVBR6jLHllRTmZuQxM7mg7Ly9vk55EMDIXEgfmOwANvH8fP8+OMwu8sbhP/IAwhYQOkiZkaABXaMa3PI2ox8hTuK7g== X-Gm-Message-State: AOJu0YwfT6KlDGGQNafFgIrabVnUBbppc5eQqTEHDCLcsQPEfroRbgXm wTBrDRh/QhSZePIrk/yqXMzFU7TNpPx2OHqADCtm9etwMNOEst1KzFJUb+l+a2g= X-Google-Smtp-Source: AGHT+IFPCOkcRJeVdtgQpzCikZSTgjJi08vN3/MxnzhnO6RmgOIxi1doJjP9XfWUOdIpaDK6m3V3fA== X-Received: by 2002:a25:ac4:0:b0:dcd:3575:db79 with SMTP id 187-20020a250ac4000000b00dcd3575db79mr8159674ybk.6.1709661645660; Tue, 05 Mar 2024 10:00:45 -0800 (PST) Received: from localhost (2603-7000-0c01-2716-da5e-d3ff-fee7-26e7.res6.spectrum.com. [2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id o15-20020ac872cf000000b0042eef160b4dsm2395504qtp.76.2024.03.05.10.00.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 10:00:45 -0800 (PST) Date: Tue, 5 Mar 2024 13:00:44 -0500 From: Johannes Weiner To: Chuck Lever Cc: Yosry Ahmed , Nhat Pham , linux-mm@kvack.org, kdevops@lists.linux.dev Subject: Re: BUG: "spinlock bad magic" Message-ID: <20240305180044.GC1491027@cmpxchg.org> References: Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Mar 05, 2024 at 12:49:20PM -0500, Chuck Lever wrote: > Hi- > > I'm testing linux-next and am seeing this BUG pop soon after the > system boots. Afterwards the system seems otherwise healthy. > > BUG: spinlock bad magic on CPU#3, kworker/3:1/41 > lock: zswap+0xd0/0x140, .magic: 00000000, .owner: /-1, .owner_cpu: 0 > CPU: 3 PID: 41 Comm: kworker/3:1 Not tainted 6.8.0-rc7-next-20240304 #1 > Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-1.fc38 04/01/2014 > Workqueue: cgroup_destroy css_killed_work_fn > Call Trace: > > dump_stack_lvl+0x8d/0xb0 > do_raw_spin_lock+0x15e/0x1b0 > ? __pfx_do_raw_spin_lock+0x10/0x10 > ? mark_held_locks+0x5d/0x90 > zswap_memcg_offline_cleanup+0x15/0x50 > mem_cgroup_css_offline+0x14a/0x1b0 > ? css_killed_work_fn+0x21/0x2c0 > css_killed_work_fn+0xb6/0x2c0 > process_one_work+0x4ac/0xb30 > ? __pfx_lock_acquire+0x10/0x10 > ? __pfx_process_one_work+0x10/0x10 > ? __list_add_valid_or_report+0x33/0xc0 > worker_thread+0x392/0x680 > ? __kthread_parkme+0xdc/0x100 > ? __pfx_worker_thread+0x10/0x10 > kthread+0x1ad/0x1f0 > ? kthread+0xf0/0x1f0 > ? __pfx_kthread+0x10/0x10 > ret_from_fork+0x30/0x50 > ? __pfx_kthread+0x10/0x10 > ret_from_fork_asm+0x1a/0x30 > Thanks Chuck, this should be addressed with a fix that Andrew just picked up: https://lore.kernel.org/mm-commits/20240305161123.CA4BCC433C7@smtp.kernel.org/T/#u