From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89D42380 for ; Thu, 7 Mar 2024 00:14:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709770469; cv=none; b=KNXRY1dj8H3huku1vm1tQkRyUDaiYGEc5o16W6SpxxVCHERnTcO7lwCsUCiE0manZJ+Pt0dFOPy10RkfsiwGBbcI28PasidAdMNRC75YBT7qrdQJJflxIciwgEdbbaEt03RYuU/2NvrHbxVAzTgBLLCo/40ECvb+70fk1FoDmCs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709770469; c=relaxed/simple; bh=nMz0hwvm6sFtPm58U/CgB0DK9SslY1jgPebljA93G+U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m0T49U259pAokslPres1lVL1s/tN/j9DQ4PCRKopfMHeGGRT5YTMfz9HDBdYiJFIBr0/WiegyODfmkCQImcCMrnaUaZe8Yfvyhaeg89qNe8ASQEqNkDFAt4VogXbyn7VP39fNdPBDjJ+QPHWbVdzRzikayQT6n9nSaZuVkCwupk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=ZaQ4TB/f; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ZaQ4TB/f" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=MY8kcNGgL3g5ywmc3TcYdjVWBJgYRGviIh0K3ZGZ6+o=; b=ZaQ4TB/fIT+QRp0qUIoxSRtImh FUGxZ8joAvkAIbi89HE3qM77mdfBpfJOhMpRs6QA2wkSHi1MeclNcQRMath9l5Ot6PpnTfB4KP7/7 DudXmDsmBWNgYAChY/gb1hD2ghbXcRUZ1jpBy5U2vOELQ/lQSSQb4/JLRq3GodnfLbs+De9Bjoc1Y bKfDfGx5GDmFtvc+WOWwgM47a3tVqSRktc29QRTn7D7xxrdxIVS+60D+PfjCMdwyZPRGoCprQW3CR xjHWGx4eIIytJ+2/gS3sgmSNzisjJU687k+vFWjnQ9Gql6huTXZJnSiT13lVJpl6m/5WuqVM/aaDU nhpwsrxw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1ri1P1-00000002N5V-0ApA; Thu, 07 Mar 2024 00:14:27 +0000 From: Luis Chamberlain To: kdevops@lists.linux.dev Cc: Luis Chamberlain Subject: [PATCH 2/5] guestfs_q35: use hex for pci addr Date: Wed, 6 Mar 2024 16:14:23 -0800 Message-ID: <20240307001426.565390-3-mcgrof@kernel.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240307001426.565390-1-mcgrof@kernel.org> References: <20240307001426.565390-1-mcgrof@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Luis Chamberlain Since we are prepending as a hex value ensure the input is converted as such. This creates no functional changes but if we later want to increase the drives beyond 9 then this will ensure we use the address space appropriately. This will become more important later when we add support for large-io experimentation to guestfs which does add tons of drives onto a guest, enough to be able to experiment with LBS support on different types of drives all in one system. Signed-off-by: Luis Chamberlain --- playbooks/roles/gen_nodes/templates/guestfs_q35.j2.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/playbooks/roles/gen_nodes/templates/guestfs_q35.j2.xml b/playbooks/roles/gen_nodes/templates/guestfs_q35.j2.xml index 86b26346..ee340aca 100644 --- a/playbooks/roles/gen_nodes/templates/guestfs_q35.j2.xml +++ b/playbooks/roles/gen_nodes/templates/guestfs_q35.j2.xml @@ -187,7 +187,7 @@ {% elif libvirt_extra_storage_drive_virtio %} {% for n in range(0,4) %} - + @@ -198,7 +198,7 @@ {% elif libvirt_extra_storage_drive_nvme %} {% for n in range(0,4) %} - + -- 2.43.0