From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9DB336F for ; Fri, 8 Mar 2024 00:04:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709856244; cv=none; b=CwvblgDHbkDB8/uevjdzjBpqX5geB2kqufzCO/boCW4US381KCm4cpznWq4tKmn8n+adT6WBl2GYGLc2TdaD1oLmLnhxAQMYOEwtUwIRLQaFXqI3lagA8uKVjoFNqA6j6lbE3aUltJh8lmrgLx3lxor1oeAnWL3HNtdftzQQLJY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709856244; c=relaxed/simple; bh=Ywwlnr8e/PFTK0bAezttvqC0I9/2rFAoTTMf6WnMcuI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YHEyMYarPNAIwbCvMmeEX52SzZlnUjmSU5dZT09hV8tb/MfH7w6LXcomIAwyfuMedkzHwUVjNxLyhv/VP8w2BwwG3wDV7bulHz5qUtQmEx5Cq8gudRY5PFg7UVJaSwQ7W1wsaacjlSjzifcPY49afV7zGTPpjibmO7HzXJCMBbI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=kP9Y36kJ; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="kP9Y36kJ" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=wJHWtFYDXx7jpBXF8JoQHyepHLo6ZR4yEhlfcjQhkw4=; b=kP9Y36kJ7CLNglPHbfY5xLwyPj z/1cdfM4Qf6wrdwWMxbS04DRFvYBvvg0gqNEaFuOnXlzF2nhah1lF1hu8qxN4KLhQVEHIW8nUKqRF I7MO7WuBCa/l08K1AoRR0udKMsIoOc8exMqSjt3Z9d9tRuL7iHh1jU/JuZ/1rQ8r+QxaQ3Uc9yxzy a/3YSf26LbPwGRfJLjhsAfXUGSybUagIfVeEU4rxBedCRj2ayGnm+1J86ofXTEJ2IxZFx/sJa1aRG D0lqIUv66c5AUt1cWWEImpeR+y7QUgC39Itz9KTNfnD0048COapR9hqPPAbkW2QJCDh6P4OZ509HR 7hFRjfvw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1riNiT-00000006uQd-1HKq; Fri, 08 Mar 2024 00:04:01 +0000 From: Luis Chamberlain To: kdevops@lists.linux.dev Cc: Luis Chamberlain Subject: [PATCH 6/8] guestfs: remove explicit tap0 device name Date: Thu, 7 Mar 2024 16:03:57 -0800 Message-ID: <20240308000400.1646823-7-mcgrof@kernel.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240308000400.1646823-1-mcgrof@kernel.org> References: <20240308000400.1646823-1-mcgrof@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Luis Chamberlain If you create more than one guest each guest will have the same tap0 device name, and when you try to start the second guest it will fail due to the clash. We can avoid this by just not specifying the target host name and letting libvirt figure it out. This does mean a slight functional change in that the host will get something like vnet+1 id instead of tap0. This fixes getting networking when using multiple guests as when testing with fstests against a filesystem. Signed-off-by: Luis Chamberlain --- playbooks/roles/gen_nodes/templates/guestfs_q35.j2.xml | 1 - playbooks/roles/gen_nodes/templates/guestfs_virt.j2.xml | 1 - 2 files changed, 2 deletions(-) diff --git a/playbooks/roles/gen_nodes/templates/guestfs_q35.j2.xml b/playbooks/roles/gen_nodes/templates/guestfs_q35.j2.xml index ce160490..9af98313 100644 --- a/playbooks/roles/gen_nodes/templates/guestfs_q35.j2.xml +++ b/playbooks/roles/gen_nodes/templates/guestfs_q35.j2.xml @@ -136,7 +136,6 @@ -
diff --git a/playbooks/roles/gen_nodes/templates/guestfs_virt.j2.xml b/playbooks/roles/gen_nodes/templates/guestfs_virt.j2.xml index 29dc0951..ee669a0b 100644 --- a/playbooks/roles/gen_nodes/templates/guestfs_virt.j2.xml +++ b/playbooks/roles/gen_nodes/templates/guestfs_virt.j2.xml @@ -128,7 +128,6 @@ -
-- 2.43.0