public inbox for kdevops@lists.linux.dev
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: kdevops@lists.linux.dev
Cc: dave@stgolabs.net, a.manzanares@samsung.com, fan.ni@samsung.com,
	jim.harris@samsung.com, Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 1/2] systemd-remote-journal: fix bridge ip for guestsfs
Date: Fri,  8 Mar 2024 01:49:49 -0800	[thread overview]
Message-ID: <20240308094951.2057614-2-mcgrof@kernel.org> (raw)
In-Reply-To: <20240308094951.2057614-1-mcgrof@kernel.org>

The IP address for the default network must be used for
the systemd-remote-journal. This can vary distro-to-distro
and so provide an easy way to describe this.

Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 kconfigs/Kconfig.ansible_provisioning | 3 ++-
 kconfigs/Kconfig.guestfs              | 6 ++++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/kconfigs/Kconfig.ansible_provisioning b/kconfigs/Kconfig.ansible_provisioning
index 2775ddff22ae..0cddf220d2f7 100644
--- a/kconfigs/Kconfig.ansible_provisioning
+++ b/kconfigs/Kconfig.ansible_provisioning
@@ -195,7 +195,8 @@ config DEVCONFIG_SYSTEMD_JOURNAL_USE_HTTP
 
 config DEVCONFIG_SYSTEMD_JOURNAL_REMOTE_URL
 	string "systemd-remote URL"
-	default "http://192.168.124.1"
+	default "http://192.168.124.1" if VAGRANT
+	default GUESTFS_DEFAULT_BRIDGE_IP if GUESTFS
 	help
           This is used for the client /etc/systemd/journal-upload.conf URL line.
           By default we won't use SSL for now. If you should make sure the
diff --git a/kconfigs/Kconfig.guestfs b/kconfigs/Kconfig.guestfs
index 03e0fb865a66..377f3434a892 100644
--- a/kconfigs/Kconfig.guestfs
+++ b/kconfigs/Kconfig.guestfs
@@ -1,5 +1,11 @@
 if GUESTFS
 
+config GUESTFS_DEFAULT_BRIDGE_IP
+       string
+       default "http://192.168.122.1" if DISTRO_FEDORA || DISTRO_REDHAT
+       default "http://192.168.122.1" if DISTRO_OPENSUSE || DISTRO_SUSE
+       default "http://192.168.122.1" if DISTRO_DEBIAN || DISTRO_UBUNTU
+
 choice
 	prompt "Guestfs Linux distribution to use"
 	default GUESTFS_FEDORA if DISTRO_FEDORA || DISTRO_REDHAT
-- 
2.43.0


  reply	other threads:[~2024-03-08  9:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-08  9:49 [PATCH 0/2] guestfs: minor fixes Luis Chamberlain
2024-03-08  9:49 ` Luis Chamberlain [this message]
2024-03-08  9:49 ` [PATCH 2/2] guestfs: wait for connections early Luis Chamberlain
2024-03-08  9:56 ` [PATCH 0/2] guestfs: minor fixes Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240308094951.2057614-2-mcgrof@kernel.org \
    --to=mcgrof@kernel.org \
    --cc=a.manzanares@samsung.com \
    --cc=dave@stgolabs.net \
    --cc=fan.ni@samsung.com \
    --cc=jim.harris@samsung.com \
    --cc=kdevops@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox