public inbox for kdevops@lists.linux.dev
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: kdevops@lists.linux.dev
Cc: dave@stgolabs.net, a.manzanares@samsung.com, fan.ni@samsung.com,
	jim.harris@samsung.com, Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 2/2] guestfs: wait for connections early
Date: Fri,  8 Mar 2024 01:49:50 -0800	[thread overview]
Message-ID: <20240308094951.2057614-3-mcgrof@kernel.org> (raw)
In-Reply-To: <20240308094951.2057614-1-mcgrof@kernel.org>

If we kick off ansible the train of ansible tasks right away
we end up timing out. The right thing to do is to wait for
connections even before we try to gather facts. So be super
explicit about that for guestfs. This will save us tons of
silly odd timeout bug reports.

Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 scripts/guestfs.Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/guestfs.Makefile b/scripts/guestfs.Makefile
index cfa59cc6bc07..af901b8ddaa0 100644
--- a/scripts/guestfs.Makefile
+++ b/scripts/guestfs.Makefile
@@ -70,6 +70,7 @@ $(KDEVOPS_PROVISIONED_SSH):
 			-e 'ansible_python_interpreter=/usr/bin/python3' ;\
 		LIBVIRT_DEFAULT_URI=$(CONFIG_LIBVIRT_URI) $(TOPDIR)/scripts/update_ssh_config_guestfs.py; \
 	fi
+	$(Q)ansible $(ANSIBLE_VERBOSE) -i hosts all -e 'ansible_python_interpreter=/usr/bin/python3' -m wait_for_connection
 	$(Q)touch $(KDEVOPS_PROVISIONED_SSH)
 
 bringup_guestfs: $(GUESTFS_BRINGUP_DEPS)
-- 
2.43.0


  parent reply	other threads:[~2024-03-08  9:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-08  9:49 [PATCH 0/2] guestfs: minor fixes Luis Chamberlain
2024-03-08  9:49 ` [PATCH 1/2] systemd-remote-journal: fix bridge ip for guestsfs Luis Chamberlain
2024-03-08  9:49 ` Luis Chamberlain [this message]
2024-03-08  9:56 ` [PATCH 0/2] guestfs: minor fixes Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240308094951.2057614-3-mcgrof@kernel.org \
    --to=mcgrof@kernel.org \
    --cc=a.manzanares@samsung.com \
    --cc=dave@stgolabs.net \
    --cc=fan.ni@samsung.com \
    --cc=jim.harris@samsung.com \
    --cc=kdevops@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox