From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B568F535A4 for ; Fri, 8 Mar 2024 09:49:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709891395; cv=none; b=mNtFPDFOG0BADWj+SXGid6YSHp+AuZN/uwLKtnjEojyx3xquE1M2ZZfuxgOE7HjDHzHyM7t4pRSob26KFrrbxBx53E3Tk2Rp/lS8fcfLzN5/LxFefc3YT4f8xH4j45s+7yNVdvierOgj48QKj8e8ahSeuKkQ0AhKHPA5P1v4m7g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709891395; c=relaxed/simple; bh=SetXlt7/Tm7cowyquKuuoPIcgatTDWY666uZLrUPT9s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dpfaRVezV7llF8/3lzq9VQH1fpBc5v15ALPrL3zrDArXPQZwSzbaocok0/bzaX0ESeXK6Nwms90l7hEV29YJEVtNEuZSqNtqIPodRw+K6GlZFwQqXECmLUuVbyCt55GVex1btODI8Kuy9UiQCKht/Ij1jEaK+zZZb4UN7Gr5yQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=1KmjVcXp; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="1KmjVcXp" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=QiQClD/OJK78GPJqHEx3lYWemM2vtSyLTTylbJkwcog=; b=1KmjVcXpXHE1WoRZxXAT2/GPo4 5vyD1pDMBmjg+E6JiaQ/+kXPLjmi7z6w2hN6rOWZnrUd7Ta4U2OP2zGcro6x7TVA1fwaUDtyV+mFv 2KNI/yPbjhNYSjZqHGhFM1QM5ZBBCEeter2OJm+U3J3no9FOLmUZuGUGNA/RBoVGtSJbWN6OraRmK TMl0P/e0SO8Zli8zfwGQFiFeP3SrMeDFNpNDzqp+5wlc5D4kqR+I51C5jeKqxXbkHXo499r8qnh0V 7l4e2brRxJIsiIhQmSUfB4BwOiYbHyqHExmIaxyFlkg5MzmveTRkFrshYjIrbP8iBO9mPZDS8+u6S 3JV77IfQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1riWrP-00000008dHc-3XH8; Fri, 08 Mar 2024 09:49:51 +0000 From: Luis Chamberlain To: kdevops@lists.linux.dev Cc: dave@stgolabs.net, a.manzanares@samsung.com, fan.ni@samsung.com, jim.harris@samsung.com, Luis Chamberlain Subject: [PATCH 2/2] guestfs: wait for connections early Date: Fri, 8 Mar 2024 01:49:50 -0800 Message-ID: <20240308094951.2057614-3-mcgrof@kernel.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240308094951.2057614-1-mcgrof@kernel.org> References: <20240308094951.2057614-1-mcgrof@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Luis Chamberlain If we kick off ansible the train of ansible tasks right away we end up timing out. The right thing to do is to wait for connections even before we try to gather facts. So be super explicit about that for guestfs. This will save us tons of silly odd timeout bug reports. Signed-off-by: Luis Chamberlain --- scripts/guestfs.Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/guestfs.Makefile b/scripts/guestfs.Makefile index cfa59cc6bc07..af901b8ddaa0 100644 --- a/scripts/guestfs.Makefile +++ b/scripts/guestfs.Makefile @@ -70,6 +70,7 @@ $(KDEVOPS_PROVISIONED_SSH): -e 'ansible_python_interpreter=/usr/bin/python3' ;\ LIBVIRT_DEFAULT_URI=$(CONFIG_LIBVIRT_URI) $(TOPDIR)/scripts/update_ssh_config_guestfs.py; \ fi + $(Q)ansible $(ANSIBLE_VERBOSE) -i hosts all -e 'ansible_python_interpreter=/usr/bin/python3' -m wait_for_connection $(Q)touch $(KDEVOPS_PROVISIONED_SSH) bringup_guestfs: $(GUESTFS_BRINGUP_DEPS) -- 2.43.0