From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8443C4084D for ; Wed, 20 Mar 2024 13:11:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710940299; cv=none; b=RJtVGqPLtkNHSeBiScRTC+no1VhCjwIN/MvWcGGqI9o+xMB0d1sRH2EeuH/hdkHjXXwH3iVkqxZnMh+G4SNZiRpAA4WhZvjEjZZyJB9OxvSm6u2Tjqv6NatfC9xgH0jR33ebTcezhKYiDWmuu6bjt+ITENFS9rtlS1Ul+quQBSQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710940299; c=relaxed/simple; bh=dkEJB4i6Fg8xIw836IqwM1N9C/uirmIiwrOuEHYyx/Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KbgwMclqsObkLAI8f4PC7Z/k/KNmi5lql63lRDh2jcLc/ASJ+auMwglPIyuZq6KHwin79nUy/qd9V1qQqIajnZlWI2lZfSwu0Jm+BxMD3FpYsMv+cSgJrj/qC2frELrNw+qsI0qTA73LnsJr5W1On97lxmj66ZkaxQv2/xZ7iu8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EGJHC169; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EGJHC169" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35693C433F1; Wed, 20 Mar 2024 13:11:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710940299; bh=dkEJB4i6Fg8xIw836IqwM1N9C/uirmIiwrOuEHYyx/Y=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=EGJHC169kOZnDYxDqrwe0LRO4RYUsVf5OW25I5FXNP5YGKIUyU/MMbiuZMQ7uK2h2 kc0XSlTbNvTJvJNXvJBpVuUU7K8FzHsTrk9nnQVbZXk+WFbquuDXlKdM/XgsBHuCjo J7bTLEz8EfbNIIj+iFSum2ljKNouxTuGet0GMUXmPP2Soq96/ysAac7c4BcEIKjnRd C672HzfXbsmCv071mhjXCqUaR2+bP+OALqBeTTAewBPbafF21eU6f6aXE+ZTSKdS2F LHby8uWy4Tcm30SNASMaxJ9a+mv1+ZfiDHndHHSH4IkbRoe1n6GZNOCOlpcCzsUOVQ cI377or5ww7Kw== From: Jeff Layton Date: Wed, 20 Mar 2024 09:11:31 -0400 Subject: [PATCH 8/8] nfsd: default to a more sane number of threads Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240320-fixes-v1-8-d1567776ad50@kernel.org> References: <20240320-fixes-v1-0-d1567776ad50@kernel.org> In-Reply-To: <20240320-fixes-v1-0-d1567776ad50@kernel.org> To: kdevops@lists.linux.dev Cc: Jeff Layton X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1304; i=jlayton@kernel.org; h=from:subject:message-id; bh=dkEJB4i6Fg8xIw836IqwM1N9C/uirmIiwrOuEHYyx/Y=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBl+uCHfctKmtJKZQUtcR5wi81p/67JjIkJBz7wm CGi+X/fhCmJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCZfrghwAKCRAADmhBGVaC FbqAD/4qJr72Jk382DjACHFGJxwcF646IYGS0H/w7LYjC1sqi22WstETZ3qeyQ4goBB7PFHtpRC ISfdm1KwY/e4Dfm489QBdhT7nVO6Y0GnW7NzA2VxbFOcAgXvMuy2HRTrUQRgfL10B3ZZx87suIb 01PDjSLdgC44Twy3VnOdMD3kOUwRBKjiV5YQ0N7gj37bDcOAM4OLSUwUc+WIOnuEdv1XrN3KPGS UVXt4kwIlBkSIEBUYcgNRfThw00baxbxyv2hz03dLj26e5a1WqJ+24/cJwNbouWcP1QEVcY2yIK qsLhzwm/z5WC7CyiLIDJPbwVJ22IRDivzmnUP5m2rbgnQAqxC9k49wiQCxAQSB72SF98j3oLlp1 ahLla9xnkOcYBT8SQABRouWd9JDvg9fEgO2XMDCEH166w1um8hdi5+8T9uekUY/0UYJe1eAwz92 rjISGsx3HMOU7n0HBILtutDJ4DMFZ+2L26L0E+cMe0XD68GjtZ0ELRD0uJfsMdaVoAOsOVjskbY wTDZpGRBoawuLXb/yFgie20C0W6Sg+Ea3VcLxSX/QJRm8x8bxeYuXpOdC87hjgoB5Xc9PQk5kDk KBHwCQfnVBxAvPfVboEavBpLlCRyAnhOD8HZwoqEFz6dz5pYbp0MWgD439s40N2AUsOIjBpxT3W Ao0O184Jegl8aRQ== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Add a small script that can estimate the number of threads for nfsd. We default to 32 threads for every GB of guest memory. Signed-off-by: Jeff Layton --- kconfigs/Kconfig.nfsd | 2 +- scripts/nfsd-thread-est.sh | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/kconfigs/Kconfig.nfsd b/kconfigs/Kconfig.nfsd index dec98c1e964f..7c28ad98955a 100644 --- a/kconfigs/Kconfig.nfsd +++ b/kconfigs/Kconfig.nfsd @@ -69,7 +69,7 @@ config NFSD_EXPORT_OPTIONS config NFSD_THREADS int "Number of nfsd threads to spawn" - default 8 + default $(shell, scripts/nfsd-thread-est.sh) help Number of nfsd threads to start up for testing. diff --git a/scripts/nfsd-thread-est.sh b/scripts/nfsd-thread-est.sh new file mode 100755 index 000000000000..dc5a1deb1215 --- /dev/null +++ b/scripts/nfsd-thread-est.sh @@ -0,0 +1,15 @@ +#!/bin/bash +# +# The default number of 8 nfsd threads is pitifully low! +# +# +# Each nfsd thread consumes ~1MB of memory, long-term: +# +# stack, kthread overhead, svc_rqst, and the rq_pages array, plus +# temporary working space. +# +# Allow 32 threads for each GB of guest memory: + +. "${TOPDIR}/.config" + +echo "$(( 32 * $CONFIG_LIBVIRT_MEM_MB / 1024 ))" -- 2.44.0