Re: [mmtests PATCH v3 1/2] bin/install-depends: call ldconfig

[Jan Kara <jack@suse.cz>]

On Fri 24-05-24 14:51:11, Luis Chamberlain wrote:
> Some packages may have bugs and forgot to run ldconfig, work around
> these bugs by ensuring we call ldconfig after installation *all*
> required packages, we do this just once for a set of packages.
> 
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>

Looks good to me. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  bin/install-depends | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/bin/install-depends b/bin/install-depends
> index e0052f274027..a7cfaa49977b 100755
> --- a/bin/install-depends
> +++ b/bin/install-depends
> @@ -254,6 +254,11 @@ foreach my $package (@ARGV) {
>  	print "Installed $package\n";
>  }
>  
> +if (system("ldconfig") != 0) {
> +	print "ERROR: ldconfig failed\n";
> +	exit(-1);
> +}
> +
>  if ($ENV{"MMTESTS_SESSION_ID"} ne "") {
>  	close(SESSION);
>  }
> -- 
> 2.43.0
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR