public inbox for kdevops@lists.linux.dev
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: kdevops@lists.linux.dev, chuck.lever@oracle.com,
	da.gomez@samsung.com, jlayton@kernel.org
Cc: mcgrof@kernel.org
Subject: [PATCH 1/3] scripts/kconfig/kconfig.Makefile: move _refs-default
Date: Wed,  4 Sep 2024 16:30:35 -0700	[thread overview]
Message-ID: <20240904233037.1516218-2-mcgrof@kernel.org> (raw)
In-Reply-To: <20240904233037.1516218-1-mcgrof@kernel.org>

We should avoid editing scripts/kconfig as much as possible unless
you are aware of the git subtree management for kconfig. So move
the old change to depend on _refs-default over to the Kconfig
dependency we had added to allow dynamic Kconfig. In the old
case we only enabled dynamic kconfigs when someone ran 'make dynconfig'
but Dan's patches which added ref tag support lets us now use dynamic
kconfig always but with minimal things: kernel branches for static
references defined in-tree on yaml files. That is we don't talk online
to fetch information.

Move the _refs-default dependency to the Kconfig dependency to make
this more explicit and to keep scripts/kconfig clean so to allow
easier updates from git subtrees.

Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 scripts/dynamic-kconfig.Makefile | 2 +-
 scripts/kconfig/kconfig.Makefile | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/dynamic-kconfig.Makefile b/scripts/dynamic-kconfig.Makefile
index bdeb499783b0..b6c0e43d6697 100644
--- a/scripts/dynamic-kconfig.Makefile
+++ b/scripts/dynamic-kconfig.Makefile
@@ -9,7 +9,7 @@ include $(TOPDIR)/scripts/dynamic-pci-kconfig.Makefile
 
 ANSIBLE_EXTRA_ARGS += $(DYNAMIC_KCONFIG_PCIE_ARGS)
 
-Kconfig: $(DYNAMIC_KCONFIG)
+Kconfig: _refs-default $(DYNAMIC_KCONFIG)
 
 dynamic-kconfig-help:
 	@echo "Dynamic kconfig targets:"
diff --git a/scripts/kconfig/kconfig.Makefile b/scripts/kconfig/kconfig.Makefile
index c537bb069264..68af73d2c0df 100644
--- a/scripts/kconfig/kconfig.Makefile
+++ b/scripts/kconfig/kconfig.Makefile
@@ -37,7 +37,7 @@ $(KCONFIG_DIR)/mconf:
 	$(MAKE) -C $(KCONFIG_DIR) mconf
 
 PHONY += menuconfig
-menuconfig: $(KCONFIG_DIR)/mconf include/config/project.release Kconfig _refs-default
+menuconfig: $(KCONFIG_DIR)/mconf include/config/project.release Kconfig
 	@$< Kconfig
 
 $(KCONFIG_DIR)/nconf:
-- 
2.43.0


  reply	other threads:[~2024-09-04 23:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-04 23:30 [PATCH 0/3] kdevops: update to latest kconfig Luis Chamberlain
2024-09-04 23:30 ` Luis Chamberlain [this message]
2024-09-04 23:30 ` [PATCH 2/3] kdevops: remove duplicate symbols and use scripts/append-makefile-vars.sh Luis Chamberlain
2024-09-04 23:30 ` [PATCH 3/3] scripts/gen-refs-default.Makefile: support direct make requests Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240904233037.1516218-2-mcgrof@kernel.org \
    --to=mcgrof@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=da.gomez@samsung.com \
    --cc=jlayton@kernel.org \
    --cc=kdevops@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox