public inbox for kdevops@lists.linux.dev
 help / color / mirror / Atom feed
From: cel@kernel.org
To: <kdevops@lists.linux.dev>
Cc: Anna Schumaker <anna@kernel.org>, Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH 1/6] fstests: Fix NFS mount options for fstests
Date: Tue, 10 Dec 2024 14:29:14 -0500	[thread overview]
Message-ID: <20241210192920.682914-2-cel@kernel.org> (raw)
In-Reply-To: <20241210192920.682914-1-cel@kernel.org>

From: Chuck Lever <chuck.lever@oracle.com>

If the NFS mount command line does not specify an NFS version, the
client uses the default protocol version , which for recent versions
of nfs-utils, is NFSv4.2.

I noticed the NFS test sections in our nfs.config file specifies the
NFS version for the test partition, but not the scratch partition.
This is throwing off the feature test macros in fstests, so it is
testing, say, xattrs, on NFSv4.1 mounts, and failing 100% of the
time.

Ensure that the test and scratch partitions use the same NFS
version.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 playbooks/roles/fstests/templates/nfs/nfs.config | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/playbooks/roles/fstests/templates/nfs/nfs.config b/playbooks/roles/fstests/templates/nfs/nfs.config
index 3605e582b2d7..b26c45c11bc3 100644
--- a/playbooks/roles/fstests/templates/nfs/nfs.config
+++ b/playbooks/roles/fstests/templates/nfs/nfs.config
@@ -21,14 +21,14 @@ MOUNT_OPTIONS="-o vers=4.1"
 
 # Test over RDMA
 [nfs_rdma]
-TEST_FS_MOUNT_OPTS="-o rdma"
+TEST_FS_MOUNT_OPTS="-o rdma,vers=4.1"
 MOUNT_OPTIONS="-o rdma,vers=4.1"
 {% endif %}
 {% if fstests_nfs_section_tls -%}
 
 # Test NFS with RPC over TLS
 [nfs_tls]
-TEST_FS_MOUNT_OPTS="-o xprtsec=mtls"
+TEST_FS_MOUNT_OPTS="-o xprtsec=mtls,vers=4.1"
 MOUNT_OPTIONS="-o xprtsec=mtls,vers=4.1"
 {% endif %}
 {% if fstests_nfs_section_nfsd -%}
-- 
2.47.0


  reply	other threads:[~2024-12-10 19:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-10 19:29 [PATCH 0/6] Recent fixes cel
2024-12-10 19:29 ` cel [this message]
2024-12-10 19:29 ` [PATCH 2/6] gen_nodes: Fix generation of the list of test nodes cel
2024-12-10 19:29 ` [PATCH 3/6] fstests: Fix selection of NFSD export type for the pNFS test section cel
2024-12-10 19:29 ` [PATCH 4/6] NFSD: Implement NVMe storage for NFSD exports cel
2024-12-11  3:42   ` Luis Chamberlain
2024-12-11 13:50     ` Chuck Lever
2024-12-12  2:28       ` Luis Chamberlain
2024-12-10 19:29 ` [PATCH 5/6] playbooks: Add a Code Ready Builder role cel
2024-12-10 19:29 ` [PATCH 6/6] codereadyrepo: Enable codeready-builder in AWS cel
2024-12-11  3:44 ` [PATCH 0/6] Recent fixes Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241210192920.682914-2-cel@kernel.org \
    --to=cel@kernel.org \
    --cc=anna@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=kdevops@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox