From: cel@kernel.org
To: <kdevops@lists.linux.dev>
Cc: Anna Schumaker <anna@kernel.org>, Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH 6/6] codereadyrepo: Enable codeready-builder in AWS
Date: Tue, 10 Dec 2024 14:29:19 -0500 [thread overview]
Message-ID: <20241210192920.682914-7-cel@kernel.org> (raw)
In-Reply-To: <20241210192920.682914-1-cel@kernel.org>
From: Chuck Lever <chuck.lever@oracle.com>
Running "make pynfs" against an AWS EC2 instance fails with:
Error: No matching repo to modify: codeready-builder-for-rhel-9-x86_64-rpms.
Adjust the logic in the codereadyrepo playbook to sketch in what
might be needed for running the pynfs workflow in AWS.
Similar adjustments might be necessary for other cloud providers.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
.../roles/codereadyrepo/defaults/main.yml | 5 +++
playbooks/roles/codereadyrepo/tasks/main.yml | 41 +++++++++++++++----
2 files changed, 37 insertions(+), 9 deletions(-)
create mode 100644 playbooks/roles/codereadyrepo/defaults/main.yml
diff --git a/playbooks/roles/codereadyrepo/defaults/main.yml b/playbooks/roles/codereadyrepo/defaults/main.yml
new file mode 100644
index 000000000000..1f1f64facf90
--- /dev/null
+++ b/playbooks/roles/codereadyrepo/defaults/main.yml
@@ -0,0 +1,5 @@
+# SPDX-License-Identifier GPL-2.0+
+---
+# Our sensible defaults for the codereadyrepo role.
+
+kdevops_enable_terraform: false
diff --git a/playbooks/roles/codereadyrepo/tasks/main.yml b/playbooks/roles/codereadyrepo/tasks/main.yml
index 71ad05c9d539..90e0bbf3d332 100644
--- a/playbooks/roles/codereadyrepo/tasks/main.yml
+++ b/playbooks/roles/codereadyrepo/tasks/main.yml
@@ -1,14 +1,37 @@
---
-- name: Enable the CodeReady repo
- become: yes
- ansible.builtin.command: /usr/bin/dnf config-manager --enable codeready-builder-for-rhel-{{ ansible_distribution_major_version }}-{{ ansible_architecture }}-rpms
+- name: Select the CodeReady repo to enable (RHEL AWS)
+ ansible.builtin.set_fact:
+ codeready_repo: "codeready-builder-for-rhel-{{ ansible_distribution_major_version }}-rhui-rpms"
when:
- - ansible_distribution == 'RedHat'
- - not devconfig_custom_yum_repofile
+ - kdevops_enable_terraform
+ - kdevops_terraform_provider == "aws"
+ - ansible_distribution == "RedHat"
-- name: Enable the CodeReady repo
- become: yes
- ansible.builtin.command: /usr/bin/dnf config-manager --enable crb
+- name: Select the CodeReady repo to enable (RHEL)
+ ansible.builtin.set_fact:
+ codeready_repo: "codeready-builder-for-rhel-{{ ansible_distribution_major_version }}-{{ ansible_architecture }}-rpms"
+ when:
+ - not kdevops_enable_terraform
+ - ansible_distribution == "RedHat"
+
+- name: Select the CodeReady repo to enable (CentOS)
+ ansible.builtin.set_fact:
+ codeready_repo: "crb"
+ when:
+ - not kdevops_enable_terraform
+ - ansible_distribution == "CentOS"
+
+- name: Enable the selected CodeReady repo
+ become: true
+ become_method: ansible.builtin.sudo
+ ansible.builtin.command:
+ argv:
+ - "/usr/bin/dnf"
+ - "config-manager"
+ - "--enable"
+ - "{{ codeready_repo }}"
+ register: dnf_result
when:
- - ansible_distribution == 'CentOS'
- not devconfig_custom_yum_repofile
+ - ansible_distribution == "RedHat" or ansible_distribution == "CentOS"
+ changed_when: dnf_result is success
--
2.47.0
next prev parent reply other threads:[~2024-12-10 19:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 19:29 [PATCH 0/6] Recent fixes cel
2024-12-10 19:29 ` [PATCH 1/6] fstests: Fix NFS mount options for fstests cel
2024-12-10 19:29 ` [PATCH 2/6] gen_nodes: Fix generation of the list of test nodes cel
2024-12-10 19:29 ` [PATCH 3/6] fstests: Fix selection of NFSD export type for the pNFS test section cel
2024-12-10 19:29 ` [PATCH 4/6] NFSD: Implement NVMe storage for NFSD exports cel
2024-12-11 3:42 ` Luis Chamberlain
2024-12-11 13:50 ` Chuck Lever
2024-12-12 2:28 ` Luis Chamberlain
2024-12-10 19:29 ` [PATCH 5/6] playbooks: Add a Code Ready Builder role cel
2024-12-10 19:29 ` cel [this message]
2024-12-11 3:44 ` [PATCH 0/6] Recent fixes Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241210192920.682914-7-cel@kernel.org \
--to=cel@kernel.org \
--cc=anna@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=kdevops@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox