public inbox for kdevops@lists.linux.dev
 help / color / mirror / Atom feed
From: cel@kernel.org
To: da.gomez@samsung.com
Cc: <kdevops@lists.linux.dev>, Chuck Lever <chuck.lever@oracle.com>,
	Joel Granados <joel.granados@kernel.org>
Subject: [RFC PATCH] devconfig: install-deps is skipped in some configurations
Date: Tue, 28 Jan 2025 12:32:33 -0500	[thread overview]
Message-ID: <20250128173233.1084701-1-cel@kernel.org> (raw)

From: Chuck Lever <chuck.lever@oracle.com>

A recent commit replaced import_tasks with include_tasks in a few
steps in the devconfig playbook.

The Ansible "import_tasks" documentation says:

> Tags are not interpreted for this action, they are applied to the
> imported tasks

Revert some of the import_tasks conversions to ensure those steps
are run according to the command-line tag settings.

For the original problem that I tripped on, add tags to ensure those
sub-steps get run as needed.

Reported-by: Joel Granados <joel.granados@kernel.org>
Closes: https://lore.kernel.org/kdevops/20250128112453.rawxqvpffxwupvco@AALNPWDAGOMEZ1.aal.scsc.local/T/#t
Fixes: e1a41cd9d4ee ("devconfig: Replace import_tasks with include_tasks")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 playbooks/roles/devconfig/tasks/main.yml | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/playbooks/roles/devconfig/tasks/main.yml b/playbooks/roles/devconfig/tasks/main.yml
index 51b890375215..84c5fa1f1cf8 100644
--- a/playbooks/roles/devconfig/tasks/main.yml
+++ b/playbooks/roles/devconfig/tasks/main.yml
@@ -32,9 +32,10 @@
 # Distro specific
 - name: Install dependencies
   ansible.builtin.include_tasks: install-deps/main.yml
+  tags: ['vars', 'vars_simple']
 
 - name: Configure custom repositories and install packages
-  ansible.builtin.include_tasks: config-custom-repos-and-packages/main.yml
+  ansible.builtin.import_tasks: config-custom-repos-and-packages/main.yml
   when:
     - ansible_facts['os_family']|lower == 'redhat'
 
@@ -447,7 +448,7 @@
   tags: [ 'console' ]
 
 - name: Update your boot GRUB file if necessary
-  ansible.builtin.include_tasks: update-grub/main.yml
+  ansible.builtin.import_tasks: update-grub/main.yml
   when:
     - grub2_config_file.stat.exists
     - devconfig_enable_console|bool
@@ -637,7 +638,7 @@
   tags: [ 'sysctl' ]
 
 - name: Rev the kernel to the latest distribution kotd
-  ansible.builtin.include_tasks: kotd-rev-kernel/main.yml
+  ansible.builtin.import_tasks: kotd-rev-kernel/main.yml
   when:
     - devconfig_enable_kotd|bool
   tags: [ 'kotd' ]
-- 
2.48.1


             reply	other threads:[~2025-01-28 17:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20250128173241eucas1p278374dceacdda4bcba7283028d65f55f@eucas1p2.samsung.com>
2025-01-28 17:32 ` cel [this message]
2025-01-29 10:40   ` [RFC PATCH] devconfig: install-deps is skipped in some configurations Daniel Gomez
2025-01-29 13:48     ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250128173233.1084701-1-cel@kernel.org \
    --to=cel@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=da.gomez@samsung.com \
    --cc=joel.granados@kernel.org \
    --cc=kdevops@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox