From: cel@kernel.org
To: <kdevops@lists.linux.dev>
Cc: Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH v1 1/4] linux-mirror: Fix installation on Fedora systems
Date: Mon, 10 Mar 2025 14:32:05 -0400 [thread overview]
Message-ID: <20250310183208.999430-2-cel@kernel.org> (raw)
In-Reply-To: <20250310183208.999430-1-cel@kernel.org>
From: Chuck Lever <chuck.lever@oracle.com>
I noticed that git-daemon was not installed when I set up the git
mirror on my Fedora 40 control host.
If "include_tasks:" has a tag, the included tasks also need to have a
"tags:" attribute or they will not be run.
Also, because my lab is already behind a firewall gateway, there
happens to be no firewall running on my controller, so the "enable
the git port" step fails with:
firewall is not currently running, unable to perform immediate actions without a running firewall daemon
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
.../roles/linux-mirror/tasks/install-deps/fedora/main.yml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/playbooks/roles/linux-mirror/tasks/install-deps/fedora/main.yml b/playbooks/roles/linux-mirror/tasks/install-deps/fedora/main.yml
index 2a93256a3d6e..01e98895cabe 100644
--- a/playbooks/roles/linux-mirror/tasks/install-deps/fedora/main.yml
+++ b/playbooks/roles/linux-mirror/tasks/install-deps/fedora/main.yml
@@ -9,6 +9,11 @@
state: present
when:
- install_linux_mirror|bool
+ tags: [ 'mirror' ]
+
+- name: Gather service facts
+ ansible.builtin.service_facts:
+ tags: [ 'mirror' ]
- name: Open the firewall on control node for git traffic
become: true
@@ -22,3 +27,6 @@
state: enabled
when:
- install_linux_mirror|bool
+ - '"firewalld.service" in ansible_facts.services'
+ - ansible_facts.services['firewalld.service'].state == "enabled"
+ tags: [ 'mirror' ]
--
2.48.1
next prev parent reply other threads:[~2025-03-10 18:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 18:32 [PATCH v1 0/4] Fixes for git mirroring on Fedora cel
2025-03-10 18:32 ` cel [this message]
2025-03-10 18:32 ` [PATCH v1 2/4] linux-mirror: Ensure git-daemon runs as the Ansible user cel
2025-03-10 18:32 ` [PATCH v1 3/4] mirror: Reduce frequency of retrieving results archive cel
2025-03-11 3:39 ` Luis Chamberlain
2025-03-11 13:38 ` Chuck Lever
2025-03-11 18:01 ` Chuck Lever
2025-03-12 5:12 ` Luis Chamberlain
2025-03-12 5:11 ` Luis Chamberlain
2025-03-10 18:32 ` [PATCH v1 4/4] linux-mirror: Add a mirror for linux-stable-rc cel
2025-03-11 3:40 ` [PATCH v1 0/4] Fixes for git mirroring on Fedora Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250310183208.999430-2-cel@kernel.org \
--to=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=kdevops@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox