From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 311A98472 for ; Tue, 1 Apr 2025 01:00:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743469214; cv=none; b=FAM1ZL9e1dqUDZbNTVTcW5R+Fd7v6XqbJsIn2blHRvLkmTQe8zkxTk97ag5idUVP9F7Gq6CmCeCFN9gajwx+ZmXrnFBRz/1pz0lM5zLbc2mIldVE5dfQIt4RUy1RWpSu0eTNRdD9XP4bosiiLcQN1gw34vvP+SGyBo5D+7WNvXI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743469214; c=relaxed/simple; bh=jQ90qyyGuoDaDw2la5U5Rk1l8K0/hUcwepHrHJGV4Gw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ondKW6dJW6lRfBz7TVWEZ+d6g84fWUQzsbwVZMU+T5Lzd8LftNWfSPASkQMO197dSfXMW/2y9x27hEdzKAgmU+mUzTTPk2rXGpfGltbXKqQQTqvmuzLzCz5Wav7r+Nb1Qx57tgpVWE9zhtN7z3I1zfQb0WL0mIO6CEtfUAwbHrc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LxTqvXeI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LxTqvXeI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1F42C4CEE5; Tue, 1 Apr 2025 01:00:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743469214; bh=jQ90qyyGuoDaDw2la5U5Rk1l8K0/hUcwepHrHJGV4Gw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LxTqvXeIFsbt5eykqLihktRvCfOwLjLXeWxR0qWgO4h5W+XCSbL7tohniz9y2SwDY mEWh6kWM2ABYXFdWYRH+3em1KHcTmVNYb+7U51iuRUyksrbg1WkgG8EoWLsR30nuf5 CwDx0+MibbQZx6evM+Vx7tLDGT5tgScIjja4jGGKclNgGGi6s1/P6IOVPiiitMdnet 16NFH11kWacBi4AWmwT05iCzxlZFwRXY133fVVyY7SUHl1Aa5Belbfdlh2qjU1KoYg 1Nyo2Lbr6Dp3QmpKY8/il7xsy67HhGJ0ePnytzieZggfQIkKqxTX6XADhEEiTarUTS OpRDUAwufnq7g== From: cel@kernel.org To: Cc: Chandan Babu R , Chuck Lever Subject: [RFC PATCH 11/31] terraform/OCI: Use "output yaml" for the fingerprint Date: Mon, 31 Mar 2025 20:59:40 -0400 Message-ID: <20250401010000.764234-12-cel@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250401010000.764234-1-cel@kernel.org> References: <20250401010000.764234-1-cel@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chuck Lever Refactor: Remove the line in terraform.Makefile that sets "terraform_oci_user_fingerprint" and just pass it directly from Kconfig via an "output yaml" directive. As an additional clean up, update the help text. Signed-off-by: Chuck Lever --- scripts/terraform.Makefile | 1 - terraform/oci/kconfigs/Kconfig.identity | 9 +++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/scripts/terraform.Makefile b/scripts/terraform.Makefile index b631b4c09a0e..75ba9b97b518 100644 --- a/scripts/terraform.Makefile +++ b/scripts/terraform.Makefile @@ -96,7 +96,6 @@ endif ifeq (y,$(CONFIG_TERRAFORM_OCI)) TERRAFORM_EXTRA_VARS += terraform_oci_region=$(subst ",,$(CONFIG_TERRAFORM_OCI_REGION)) -TERRAFORM_EXTRA_VARS += terraform_oci_user_fingerprint=$(subst ",,$(CONFIG_TERRAFORM_OCI_USER_FINGERPRINT)) TERRAFORM_EXTRA_VARS += terraform_oci_availablity_domain=$(subst ",,$(CONFIG_TERRAFORM_OCI_AVAILABLITY_DOMAIN)) TERRAFORM_EXTRA_VARS += terraform_oci_compartment_ocid=$(subst ",,$(CONFIG_TERRAFORM_OCI_COMPARTMENT_OCID)) TERRAFORM_EXTRA_VARS += terraform_oci_shape=$(subst ",,$(CONFIG_TERRAFORM_OCI_SHAPE)) diff --git a/terraform/oci/kconfigs/Kconfig.identity b/terraform/oci/kconfigs/Kconfig.identity index 87f5457995f5..310cf19b7ca1 100644 --- a/terraform/oci/kconfigs/Kconfig.identity +++ b/terraform/oci/kconfigs/Kconfig.identity @@ -27,8 +27,9 @@ config TERRAFORM_OCI_USER_PRIVATE_KEY_PATH https://docs.oracle.com/en-us/iaas/Content/API/Concepts/apisigningkey.htm#two config TERRAFORM_OCI_USER_FINGERPRINT - string "OCI user fingerprint" + string "Signing key fingerprint" + output yaml help - Fingerprint for the key pair being used. - Read this: - https://docs.oracle.com/en-us/iaas/Content/API/SDKDocs/terraformproviderconfiguration.htm + Fingerprint for the signing key pair. See: + + https://docs.oracle.com/en-us/iaas/Content/API/Concepts/apisigningkey.htm#four -- 2.48.1