public inbox for kdevops@lists.linux.dev
 help / color / mirror / Atom feed
From: cel@kernel.org
To: <kdevops@lists.linux.dev>
Cc: Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH v2 3/4] Replace STORAGE_POOL_PATH with LIBVIRT_STORAGE_POOL_PATH
Date: Mon, 14 Apr 2025 13:05:45 -0400	[thread overview]
Message-ID: <20250414170546.1995982-4-cel@kernel.org> (raw)
In-Reply-To: <20250414170546.1995982-1-cel@kernel.org>

From: Chuck Lever <chuck.lever@oracle.com>

Clean up.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 kconfigs/Kconfig.guestfs                                  | 5 -----
 .../roles/libvirt_user/tasks/enable-user/redhat/main.yml  | 8 ++++----
 2 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/kconfigs/Kconfig.guestfs b/kconfigs/Kconfig.guestfs
index 460ee703fd68..a2fddd691be9 100644
--- a/kconfigs/Kconfig.guestfs
+++ b/kconfigs/Kconfig.guestfs
@@ -1,10 +1,5 @@
 if GUESTFS
 
-config STORAGE_POOL_PATH
-	string
-	output yaml
-	default LIBVIRT_STORAGE_POOL_PATH
-
 config GUESTFS_STORAGE_DIR
 	string
 	output yaml
diff --git a/playbooks/roles/libvirt_user/tasks/enable-user/redhat/main.yml b/playbooks/roles/libvirt_user/tasks/enable-user/redhat/main.yml
index 1a18c4b4f29f..717d8ef68569 100644
--- a/playbooks/roles/libvirt_user/tasks/enable-user/redhat/main.yml
+++ b/playbooks/roles/libvirt_user/tasks/enable-user/redhat/main.yml
@@ -35,16 +35,16 @@
   when:
     - only_verify_user|bool
 
-- name: Test SELinux context of {{ storage_pool_path }}
-  command: "/usr/bin/stat -c %C {{ storage_pool_path }}"
+- name: Test SELinux context of {{ libvirt_storage_pool_path }}
+  command: "/usr/bin/stat -c %C {{ libvirt_storage_pool_path }}"
   register: storage_pool_path_ctx
   when:
     - only_verify_user|bool
 
-- name: Set SELinux context on {{ storage_pool_path }}
+- name: Set SELinux context on {{ libvirt_storage_pool_path }}
   become: yes
   community.general.sefcontext:
-    target: "{{ storage_pool_path }}(/.*)?"
+    target: "{{ libvirt_storage_pool_path }}(/.*)?"
     setype: svirt_home_t
     state: present
   when:
-- 
2.49.0


  parent reply	other threads:[~2025-04-14 17:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-14 17:05 [PATCH v2 0/4] Add uniquifier to storage pool path cel
2025-04-14 17:05 ` [PATCH v2 1/4] guestfs: Fix definition of guestfs_storage_dir cel
2025-04-23  6:36   ` Luis Chamberlain
2025-04-14 17:05 ` [PATCH v2 2/4] install_vagrant: Remove this role cel
2025-04-23  6:23   ` Luis Chamberlain
2025-04-14 17:05 ` cel [this message]
2025-04-23  6:37   ` [PATCH v2 3/4] Replace STORAGE_POOL_PATH with LIBVIRT_STORAGE_POOL_PATH Luis Chamberlain
2025-04-14 17:05 ` [PATCH v2 4/4] guestfs: Per-user storage pools cel
2025-04-14 21:08   ` Chuck Lever
2025-04-23  6:22 ` [PATCH v2 0/4] Add uniquifier to storage pool path Luis Chamberlain
2025-04-23  6:42   ` Luis Chamberlain
2025-04-23 14:01   ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250414170546.1995982-4-cel@kernel.org \
    --to=cel@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=kdevops@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox