From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8F37A32 for ; Wed, 16 Apr 2025 13:41:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744810866; cv=none; b=KrJYcYmlEzMiT2OIePPgIyfMtoomY0fXplWf2D90JWz+3cfZ++reNj9gD1VBXQDJgoRaMcsvwfpOy6TM/ehUSE9Re8vRl+oBU+v3ml4LVeF87p/AlkMpIA2hh8ey1NPKfQsn39yjt8n3QjhUuaOOn6U8vtMImgci5M+1S3BIQbw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744810866; c=relaxed/simple; bh=yTVVhOP/JZWtXueRdFejApG6QUk8+eAXYkpez3B0578=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mh26Z290f6HfAwppuTSvznlRWmo1DFIm2aauP1Pd4mVo9oZBprq7cOSDG9dm+d2MQYDosLgsaaOkDXCd4pb9Vy9uT/3efn0vtIGsiYJSWbj/v3VfjG4GuZhVAS39eAUiCzKz4OlFF+S03bVsErqTOz4qF1+qtu/GK0qDHhaOz7M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HQYyIAjF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HQYyIAjF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6A08C4CEED; Wed, 16 Apr 2025 13:41:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744810866; bh=yTVVhOP/JZWtXueRdFejApG6QUk8+eAXYkpez3B0578=; h=From:To:Cc:Subject:Date:From; b=HQYyIAjFo+L4uOnXGkPSCaejrdUeAX9VMKINrSzcoa8r5h95fAhkGGTjv6bri/FUj y9jGR+uipNXXJsdP/bDplJe8FAolsWfec9Eyw+jCs79DqWn0/jxUsKZDsvt4UMOmd+ XMCEodNV5jMyGVyyTpKjktI73QtQHx+1yDEd3i6KSC5RKDDekTKSMK5bZCVCQeoJ/c 8R7vsyQLefRrJyT/eXL3bXX7+H4imEuNlRQ1ZYQdEqqmrUbiXHFflao0CfqKKD5HmQ Xk5gLo2b+6MPQU1NP3WXkjUwEOtPSZgKoq+YqLKzszfCRHkn2fCy4K1/Ix6oxD89T/ QHTdP1Hp6d2lQ== From: cel@kernel.org To: Daniel Gomez Cc: , Chuck Lever Subject: [PATCH] ansible_cfg: template boolean defaults must be "False" Date: Wed, 16 Apr 2025 09:41:03 -0400 Message-ID: <20250416134103.2917189-1-cel@kernel.org> X-Mailer: git-send-email 2.49.0 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chuck Lever I found that the "disable_skipped_hosts" Kconfig setting was not working. Using "output yaml" with a boolean behaves somewhat counter- intuitively. When the user specifies "Yes, please set this", the variable appears in .extra_vars_auto.yaml with a value of True. When the user specifies "No, please do not set this" the variable does not appear in .extra_vars_auto.yaml at all. To make a template that uses these variables behave correctly, then, the defaults/main.yml setting has to be False always. When the Kconfig setting is enabled, that will override this default. Signed-off-by: Chuck Lever --- playbooks/roles/ansible_cfg/defaults/main.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/playbooks/roles/ansible_cfg/defaults/main.yml b/playbooks/roles/ansible_cfg/defaults/main.yml index e01de2f4481d..4ff00c18976d 100644 --- a/playbooks/roles/ansible_cfg/defaults/main.yml +++ b/playbooks/roles/ansible_cfg/defaults/main.yml @@ -1,12 +1,12 @@ --- -ansible_cfg_deprecation_warnings: true +ansible_cfg_deprecation_warnings: false ansible_cfg_callback_plugin_string: dense ansible_cfg_callback_plugin_check_mode_markers: false ansible_cfg_callback_plugin_display_failed_stderr: false -ansible_cfg_callback_plugin_display_ok_hosts: true -ansible_cfg_callback_plugin_display_skipped_hosts: true +ansible_cfg_callback_plugin_display_ok_hosts: false +ansible_cfg_callback_plugin_display_skipped_hosts: false ansible_cfg_callback_plugin_show_custom_stats: false -ansible_cfg_callback_plugin_show_per_host_start: true -ansible_cfg_callback_plugin_show_task_path_on_failure: true +ansible_cfg_callback_plugin_show_per_host_start: false +ansible_cfg_callback_plugin_show_task_path_on_failure: false ansible_cfg_interpreter_python: "auto_silent" ansible_cfg_forks: 10 -- 2.49.0