From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F1D9253328 for ; Thu, 17 Apr 2025 15:13:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744902817; cv=none; b=C1isLuPg0EW6bWAsdvZdQvvgNsGvGHF8lNF74XyH97nk1xlXIV/Kwh/dFjZpBACsiI2cf/15c0B4gISRqd6v0fYxCbPHeppMZPO58oGP6/aN5TtLu3p/vn3yvgCHNPlAK7AlqJAKGZAQ+tboehAtpmZLTbyZldmSv9jxk6VPco4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744902817; c=relaxed/simple; bh=Eyw8WGBRbc/I7MsgV+iK7xLRFiz6Qhd4LfQJFbTMAKA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=cFhtdr1O20TDdAGFK4WIIQkZ6Z6IJTNCFKIT0FHObsLmkn8QfgCJa8UFhHk3zYe4gT6d0cuns5Mk5LjJH9D8x6h1o2YMVmW6SLcYTkBUm1ADSUXsU2OVQxKajbcMiMZTEXlqj/Dr4tgQR4XQ6ZaHpdE636jCw0yz+0L2WOBituA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iBiECJDg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iBiECJDg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6FFBC4CEE4; Thu, 17 Apr 2025 15:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744902817; bh=Eyw8WGBRbc/I7MsgV+iK7xLRFiz6Qhd4LfQJFbTMAKA=; h=From:To:Cc:Subject:Date:From; b=iBiECJDgeDs2ZDREaCGE2YJs1lkg+UDJjvsUAyEwZMvFllPFc5w4f8riLXMw/O7JJ zubajBPlt7HdftJ0T+tw4tVcuK2Km48uEOfdsW8W4k2eWhzi2LUaCcceTODVmhLD7u Q5MF/VQNYpCvpAhH7jsGnN9Y2Kxdha1ZPh9ULi9jLPmcnk1XIoxrBIMKQ5e18jIhwc tFKGc7Zt3UaUkd73GdXrO+o1XxgFMf+LQDkqQ2xAuvbUILNgfgbNHo9fVrLyh5WlY4 qpxj+wshFnp8gAqquWtpwo4rZlU+xzzGBuri0EgjrFYGWhqAiiXY4chQLjRmrmmPeW 5D4FQnocLozKw== From: cel@kernel.org To: Daniel Gomez Cc: , Chuck Lever Subject: [PATCH] kconfig: "output yaml" renders boolean N as a comment Date: Thu, 17 Apr 2025 11:13:34 -0400 Message-ID: <20250417151334.3135530-1-cel@kernel.org> X-Mailer: git-send-email 2.49.0 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chuck Lever I found that the "disable_skipped_hosts" Kconfig setting was not working. Using "output yaml" with a boolean behaves somewhat counter- intuitively. When the user specifies "Yes, please set this", the variable appears in .extra_vars_auto.yaml with a value of True. When the user specifies "No, please do not set this" the variable does not appear in .extra_vars_auto.yaml at all. A more convenient and sensible behavior would be for "output yaml" to output false Kconfig settings with an explicit "variable: False". Suggested-by: Daniel Gomez Signed-off-by: Chuck Lever --- scripts/kconfig/confdata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c index aaab17f401e8..88bb13e6d842 100644 --- a/scripts/kconfig/confdata.c +++ b/scripts/kconfig/confdata.c @@ -736,7 +736,7 @@ static void __print_yaml_symbol(FILE *fp, struct symbol *sym, static void print_symbol_for_dotconfig(FILE *fp, FILE *yaml, struct symbol *sym) { __print_symbol(fp, sym, OUTPUT_N_AS_UNSET, true); - __print_yaml_symbol(yaml, sym, OUTPUT_N_AS_UNSET, true); + __print_yaml_symbol(yaml, sym, OUTPUT_N, true); } static void print_symbol_for_autoconf(FILE *fp, struct symbol *sym) -- 2.49.0