public inbox for kdevops@lists.linux.dev
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Chuck Lever <cel@kernel.org>, Daniel Gomez <da.gomez@kruces.com>,
	kdevops@lists.linux.dev
Cc: Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH v2 1/2] devconfig: localize unnattended-upgrades sanity check
Date: Fri, 18 Apr 2025 12:24:13 -0700	[thread overview]
Message-ID: <20250418192414.4192280-2-mcgrof@kernel.org> (raw)
In-Reply-To: <20250418192414.4192280-1-mcgrof@kernel.org>

Commit 4680fce19494e ("devconfig: ensure unattended-upgrades is not
installed on debian") was a bit too broad. We want this check only
for guestfs setups.

Fixes: 4680fce19494e ("devconfig: ensure unattended-upgrades is not installed on debian")
Reported-by: Chuck Lever <cel@kernel.org>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 playbooks/roles/devconfig/defaults/main.yml                  | 1 +
 playbooks/roles/devconfig/tasks/install-deps/debian/main.yml | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/playbooks/roles/devconfig/defaults/main.yml b/playbooks/roles/devconfig/defaults/main.yml
index 66e78490ab31..2584eb843786 100644
--- a/playbooks/roles/devconfig/defaults/main.yml
+++ b/playbooks/roles/devconfig/defaults/main.yml
@@ -54,5 +54,6 @@ devconfig_enable_systemd_timesyncd_ntp: False
 devconfig_enable_systemd_timesyncd_ntp_google: False
 devconfig_enable_systemd_timesyncd_ntp_debian: False
 devconfig_enable_systemd_timesyncd_ntp_google_debian: False
+kdevops_enable_guestfs: False
 guestfs_copy_sources_from_host_to_guest: False
 distro_debian_has_hop1_sources: False
diff --git a/playbooks/roles/devconfig/tasks/install-deps/debian/main.yml b/playbooks/roles/devconfig/tasks/install-deps/debian/main.yml
index 954f0aede3b2..8efc59bc167f 100644
--- a/playbooks/roles/devconfig/tasks/install-deps/debian/main.yml
+++ b/playbooks/roles/devconfig/tasks/install-deps/debian/main.yml
@@ -8,6 +8,8 @@
 - name: Set fact if unattended-upgrades is installed
   set_fact:
     unattended_upgrades_installed: "{{ 'install ok installed' in unattended_upgrade_status.stdout }}"
+  when:
+    - kdevops_enable_guestfs|bool
 
 - name: Verify unattended-upgrades is not installed
   fail:
@@ -19,6 +21,7 @@
       make cleancache
       make bringup
   when:
+    - kdevops_enable_guestfs|bool
     - unattended_upgrades_installed|bool
 
 - name: Upgrade Packages
-- 
2.47.2


  reply	other threads:[~2025-04-18 19:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-18 19:24 [PATCH v2 0/2] devconfig: firstconfig enhancements Luis Chamberlain
2025-04-18 19:24 ` Luis Chamberlain [this message]
2025-04-18 19:24 ` [PATCH v2 2/2] devconfig: enhance firstconfig on debian Luis Chamberlain
2025-04-18 19:30 ` [PATCH v2 0/2] devconfig: firstconfig enhancements Chuck Lever
2025-04-18 19:36   ` Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250418192414.4192280-2-mcgrof@kernel.org \
    --to=mcgrof@kernel.org \
    --cc=cel@kernel.org \
    --cc=da.gomez@kruces.com \
    --cc=kdevops@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox