From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 135F72F43 for ; Fri, 18 Apr 2025 19:24:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745004257; cv=none; b=MQmvgc/mmw/LYQNrcBJJV0qCEEL8VW0rRIR0orSZMJeX98nGxliuQgebh5FJBGzQgl8PLcDBrC0MnXtdr6Bc3kAVdKipIA7yyJIXGL8/punWrPlAmioZKCJoAL4Xjucln7ZsAU/AZZWnFIeYDe5r2g080umJjWYdBOt66adkor4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745004257; c=relaxed/simple; bh=e2taRgA253/Ic/tINS+4iu2BvNM8sKGVzT5ZL241l+Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d/h4qBdsKNZc69W0soOYqJ0MH9jgJL7Goy2Y6UbblA9Fuea8mUm2SuBiuS2hpUmW7KAgC5hYyuCA/WYjEIeB7tRwzE1443nRSJ9+NvVtRmow2PbdL9LwqtLUnVF1jrOtvWzLf6j5p0pQobXofofHqcSpXv4XOJp5g8nurME8ISU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=1G2/nCYb; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="1G2/nCYb" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=hVsuU3krfZeA4NV3oajnR9GUogcrhBeXSG1ahthNe6w=; b=1G2/nCYbj0+Mw7+bXLPWX0uNU3 JlDbBkZWUQr3GY5nHV7AcSKP40D8q5mbQQkOXgGgNdpgTjifIJd+d2ba4/2iEG65swWSRcbONkCwx WCM7igTwUbaZulx/hrg6kIiQGqBZSeUj/3atd3uNM0lO4fnMSh1NDDhhCtmO6kRxht9zDluBKl55t MCL7cmb2OFvt+DELw9VPJpHTgeHbLjxVUddnjF1b0e6umfbyilGYB/lrFZRidvjKFQQAOkxMdnQ0c eVl9ZKpkiWoVzv4Yhw3xe+g7mJ1IjC0vttSD0R3TvCLTF+cF38uLGJlMlGy2AVT7PFNIcQfC4PGq7 q1tFIwZw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1u5rJv-0000000Habb-237i; Fri, 18 Apr 2025 19:24:15 +0000 From: Luis Chamberlain To: Chuck Lever , Daniel Gomez , kdevops@lists.linux.dev Cc: Luis Chamberlain Subject: [PATCH v2 1/2] devconfig: localize unnattended-upgrades sanity check Date: Fri, 18 Apr 2025 12:24:13 -0700 Message-ID: <20250418192414.4192280-2-mcgrof@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250418192414.4192280-1-mcgrof@kernel.org> References: <20250418192414.4192280-1-mcgrof@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Luis Chamberlain Commit 4680fce19494e ("devconfig: ensure unattended-upgrades is not installed on debian") was a bit too broad. We want this check only for guestfs setups. Fixes: 4680fce19494e ("devconfig: ensure unattended-upgrades is not installed on debian") Reported-by: Chuck Lever Signed-off-by: Luis Chamberlain --- playbooks/roles/devconfig/defaults/main.yml | 1 + playbooks/roles/devconfig/tasks/install-deps/debian/main.yml | 3 +++ 2 files changed, 4 insertions(+) diff --git a/playbooks/roles/devconfig/defaults/main.yml b/playbooks/roles/devconfig/defaults/main.yml index 66e78490ab31..2584eb843786 100644 --- a/playbooks/roles/devconfig/defaults/main.yml +++ b/playbooks/roles/devconfig/defaults/main.yml @@ -54,5 +54,6 @@ devconfig_enable_systemd_timesyncd_ntp: False devconfig_enable_systemd_timesyncd_ntp_google: False devconfig_enable_systemd_timesyncd_ntp_debian: False devconfig_enable_systemd_timesyncd_ntp_google_debian: False +kdevops_enable_guestfs: False guestfs_copy_sources_from_host_to_guest: False distro_debian_has_hop1_sources: False diff --git a/playbooks/roles/devconfig/tasks/install-deps/debian/main.yml b/playbooks/roles/devconfig/tasks/install-deps/debian/main.yml index 954f0aede3b2..8efc59bc167f 100644 --- a/playbooks/roles/devconfig/tasks/install-deps/debian/main.yml +++ b/playbooks/roles/devconfig/tasks/install-deps/debian/main.yml @@ -8,6 +8,8 @@ - name: Set fact if unattended-upgrades is installed set_fact: unattended_upgrades_installed: "{{ 'install ok installed' in unattended_upgrade_status.stdout }}" + when: + - kdevops_enable_guestfs|bool - name: Verify unattended-upgrades is not installed fail: @@ -19,6 +21,7 @@ make cleancache make bringup when: + - kdevops_enable_guestfs|bool - unattended_upgrades_installed|bool - name: Upgrade Packages -- 2.47.2