From: cel@kernel.org
To: <kdevops@lists.linux.dev>
Cc: Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH v4 1/3] scripts: Remove unused kdevops_storage_pool_user variable
Date: Thu, 24 Apr 2025 10:17:23 -0400 [thread overview]
Message-ID: <20250424141725.827244-2-cel@kernel.org> (raw)
In-Reply-To: <20250424141725.827244-1-cel@kernel.org>
From: Chuck Lever <chuck.lever@oracle.com>
I would like to reuse this variable name. Two places define it,
currently, but otherwise it appears to be unused.
Clean up: Remove the places that define the variable.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
scripts/guestfs.Makefile | 1 -
scripts/vagrant.Makefile | 2 --
2 files changed, 3 deletions(-)
diff --git a/scripts/guestfs.Makefile b/scripts/guestfs.Makefile
index 3dad6a14f0c5..43bbea4fda2e 100644
--- a/scripts/guestfs.Makefile
+++ b/scripts/guestfs.Makefile
@@ -10,7 +10,6 @@ export KDEVOPS_PROVISIONED_SSH := $(KDEVOPS_PROVISIONED_SSH_DEFAULT_GUARD)
GUESTFS_ARGS += guestfs_path='$(TOPDIR_PATH)/guestfs'
GUESTFS_ARGS += data_home_dir=/home/kdevops
GUESTFS_ARGS += virtbuilder_os_version=$(CONFIG_VIRT_BUILDER_OS_VERSION)
-GUESTFS_ARGS += kdevops_storage_pool_user='$(USER)'
GUESTFS_ARGS += libvirt_provider=True
diff --git a/scripts/vagrant.Makefile b/scripts/vagrant.Makefile
index fc69fb91f53f..e43a21d3c056 100644
--- a/scripts/vagrant.Makefile
+++ b/scripts/vagrant.Makefile
@@ -30,8 +30,6 @@ else
VAGRANT_PRIVATE_BOX_DEPS :=
endif
-VAGRANT_ARGS += kdevops_storage_pool_user='$(USER)'
-
ifeq (y,$(CONFIG_LIBVIRT))
VAGRANT_ARGS += libvirt_provider=True
--
2.49.0
next prev parent reply other threads:[~2025-04-24 14:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 14:17 [PATCH v4 0/3] Add uniquifier to storage pool path cel
2025-04-24 14:17 ` cel [this message]
2025-04-24 14:17 ` [PATCH v4 2/3] Kconfig: Define KDEVOPS_STORAGE_POOL_USER via Kconfig cel
2025-04-24 14:17 ` [PATCH v4 3/3] guestfs: Per-user storage pools cel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250424141725.827244-2-cel@kernel.org \
--to=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=kdevops@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox