From: Daniel Gomez <da.gomez@kernel.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: kdevops@lists.linux.dev, Daniel Gomez <da.gomez@kernel.org>,
Daniel Gomez <da.gomez@samsung.com>
Subject: [PATCH 2/2] generate_refs: prioritize static refs in gitref generation
Date: Thu, 15 May 2025 10:06:20 +0200 [thread overview]
Message-ID: <20250515-gitref-fixes-v1-2-cbd37288d5b9@samsung.com> (raw)
In-Reply-To: <20250515-gitref-fixes-v1-0-cbd37288d5b9@samsung.com>
From: Daniel Gomez <da.gomez@samsung.com>
Change the order of reference generation in gitref to prioritize static
references. This ensures that a static ref, appears first in the list
and is selected by default.
Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
---
scripts/generate_refs.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/generate_refs.py b/scripts/generate_refs.py
index e7032000bbac24ac872b83c7d962c8ee097064b2..4bd179b9ddfdfa7421c4ba66f3cf3b370287dfe7 100755
--- a/scripts/generate_refs.py
+++ b/scripts/generate_refs.py
@@ -202,7 +202,6 @@ def ref_generator(args, reflist, extraconfs) -> None:
f.write('\tprompt "Tag or branch to use"\n\n')
logging.debug("Generating...")
- refs.update(_ref_generator_choices(args, reflist, len(refs)))
if extraconfs:
for config in extraconfs:
@@ -212,6 +211,8 @@ def ref_generator(args, reflist, extraconfs) -> None:
)
)
+ refs.update(_ref_generator_choices(args, reflist, len(refs)))
+
with open(args.output, "a") as f:
f.write("endchoice\n\n")
f.write("config {}_REF\n".format(args.prefix))
--
2.49.0
next prev parent reply other threads:[~2025-05-15 8:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 8:06 [PATCH 0/2] Git reference handling improvements Daniel Gomez
2025-05-15 8:06 ` [PATCH 1/2] generate_refs: fix gitref duplicated refs Daniel Gomez
2025-05-15 8:06 ` Daniel Gomez [this message]
2025-05-15 17:26 ` [PATCH 0/2] Git reference handling improvements Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250515-gitref-fixes-v1-2-cbd37288d5b9@samsung.com \
--to=da.gomez@kernel.org \
--cc=da.gomez@samsung.com \
--cc=kdevops@lists.linux.dev \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox