From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BF071E502 for ; Sun, 18 May 2025 14:18:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747577921; cv=none; b=UZirYwF4r1jtFHvCm9LWuSR93TkMJkg91JWeTmJKXBFhKcwTloCZTG7sFGwlfidNoNbUuxVMSI0sLVSknd0uTxDK2hHdza2Dd/7scevigj3d/erDw5T3JoH1QU3Kp47cp2+D/sPkYu8NSVn2WQ3ex22Q6Rgzy96QmEVjYlVM62Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747577921; c=relaxed/simple; bh=CGLVDh3cIZ5hLT4vlor4QCzD5liv9WOcebs5+2ssFFY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kpnz3wkPYu+OHYiTiBaWvLVtc/HUNXodX7X5EdDwzfZfjDd7dtU3b8mXselicJQD8j0REIExarp3aCyx9Yk2EYeYSrW3R56VMdiaUQiqRq6tYu3Q7vghLwjBZ6tQFITMRUvpX+kTb/zuqpEUMuOOaZW+LbilxB6Iks+HdrkyLwQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Cso2qyQg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Cso2qyQg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B187C4CEE7; Sun, 18 May 2025 14:18:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747577920; bh=CGLVDh3cIZ5hLT4vlor4QCzD5liv9WOcebs5+2ssFFY=; h=From:To:Cc:Subject:Date:From; b=Cso2qyQg48xjU9cRvG24UcqZ3BRBNXFQ4adQSjKgw+/FfUq1XGv0stWu4bbSGbmKV fpYLElxq97zI57+563Z1GBFgx1yMC2I+83HgcMlAQnmwa5WJM+8N3OM7jLc02hDtmf A0YuzMUfiJDjrx26XA3dXPM6yZohgzZW1xQiC0pC+BvjyDiNQQhBaIqss7DHHpUS6M JK2pyVbNKz4t/U0LtoSXeEXJZpbJ0IRTPAF7hy7iQssYxsETO47SrLMowrMExtpuUr +S5CxDy6AYrxc+ANorSXipul4H2PxuACMXe+MDS0vMdBpnsq2atoEMj80oOyCcS15H cYKoZuu/SzGXA== From: cel@kernel.org To: Cc: Daniel Gomez , Chuck Lever Subject: [PATCH v1 1/2] bootlinux: Modernize install-deps/main.yml Date: Sun, 18 May 2025 10:18:37 -0400 Message-ID: <20250518141838.176772-1-cel@kernel.org> X-Mailer: git-send-email 2.49.0 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chuck Lever This subrole is run using include_tasks, but install-deps/main.yml then imports the distribution-specific steps. It's better to avoid mixing import_tasks and include_tasks. Signed-off-by: Chuck Lever --- .../bootlinux/tasks/install-deps/main.yml | 21 ++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/playbooks/roles/bootlinux/tasks/install-deps/main.yml b/playbooks/roles/bootlinux/tasks/install-deps/main.yml index c4c16d20509c..2931f9fe06e3 100644 --- a/playbooks/roles/bootlinux/tasks/install-deps/main.yml +++ b/playbooks/roles/bootlinux/tasks/install-deps/main.yml @@ -1,8 +1,15 @@ --- -- name: oscheck distribution ospecific setup - import_tasks: debian/main.yml - when: ansible_facts['os_family']|lower == 'debian' -- import_tasks: suse/main.yml - when: ansible_facts['os_family']|lower == 'suse' -- import_tasks: redhat/main.yml - when: ansible_facts['os_family']|lower == 'redhat' +- name: Debian-specific setup + ansible.builtin.include_tasks: debian/main.yml + when: + - ansible_os_family == "Debian" + +- name: SuSE-specific setup + ansible.builtin.include_tasks: suse/main.yml + when: + - ansible_os_family == "Suse" + +- name: Red Hat-specific setup + ansible.builtin.include_tasks: redhat/main.yml + when: + - ansible_os_family == "RedHat" -- 2.49.0