public inbox for kdevops@lists.linux.dev
 help / color / mirror / Atom feed
From: cel@kernel.org
To: <kdevops@lists.linux.dev>
Cc: Daniel Gomez <da.gomez@kernel.org>, Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH v2 2/4] bootlinux: Modernize install-deps/main.yml
Date: Mon, 19 May 2025 12:21:29 -0400	[thread overview]
Message-ID: <20250519162131.381359-3-cel@kernel.org> (raw)
In-Reply-To: <20250519162131.381359-1-cel@kernel.org>

From: Chuck Lever <chuck.lever@oracle.com>

Clean-up: Address ansible-lint complaints:

fqcn[action-core]: Use FQCN for builtin module actions (import_tasks).
playbooks/roles/bootlinux/tasks/install-deps/main.yml:2 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead.

name[casing]: All names should start with an uppercase letter.
playbooks/roles/bootlinux/tasks/install-deps/main.yml:2 Task/Handler: oscheck distribution ospecific setup

fqcn[action-core]: Use FQCN for builtin module actions (import_tasks).
playbooks/roles/bootlinux/tasks/install-deps/main.yml:5 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead.

name[missing]: All tasks should be named.
playbooks/roles/bootlinux/tasks/install-deps/main.yml:5 Task/Handler: import_tasks suse/main.yml

fqcn[action-core]: Use FQCN for builtin module actions (import_tasks).
playbooks/roles/bootlinux/tasks/install-deps/main.yml:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead.

name[missing]: All tasks should be named.
playbooks/roles/bootlinux/tasks/install-deps/main.yml:7 Task/Handler: import_tasks redhat/main.yml

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 .../bootlinux/tasks/install-deps/main.yml     | 21 ++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/playbooks/roles/bootlinux/tasks/install-deps/main.yml b/playbooks/roles/bootlinux/tasks/install-deps/main.yml
index c4c16d20509c..51a207416ad3 100644
--- a/playbooks/roles/bootlinux/tasks/install-deps/main.yml
+++ b/playbooks/roles/bootlinux/tasks/install-deps/main.yml
@@ -1,8 +1,15 @@
 ---
-- name: oscheck distribution ospecific setup
-  import_tasks: debian/main.yml
-  when: ansible_facts['os_family']|lower == 'debian'
-- import_tasks: suse/main.yml
-  when: ansible_facts['os_family']|lower == 'suse'
-- import_tasks: redhat/main.yml
-  when: ansible_facts['os_family']|lower == 'redhat'
+- name: Debian-specific setup
+  ansible.builtin.import_tasks: debian/main.yml
+  when:
+    - ansible_os_family == "Debian"
+
+- name: SuSE-specific setup
+  ansible.builtin.import_tasks: suse/main.yml
+  when:
+    - ansible_os_family == "Suse"
+
+- name: Red Hat-specific setup
+  ansible.builtin.import_tasks: redhat/main.yml
+  when:
+    - ansible_os_family == "RedHat"
-- 
2.49.0


  parent reply	other threads:[~2025-05-19 16:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-19 16:21 [PATCH v2 0/4] Remove the bootlinux-local role cel
2025-05-19 16:21 ` [PATCH v2 1/4] bootlinux: Remove the 'linux' tag cel
2025-05-20 20:43   ` Daniel Gomez
2025-05-19 16:21 ` cel [this message]
2025-05-20 18:27   ` [PATCH v2 2/4] bootlinux: Modernize install-deps/main.yml Daniel Gomez
2025-05-19 16:21 ` [PATCH v2 3/4] bootlinux: Switch to import_tasks for install-deps cel
2025-05-20 20:33   ` Daniel Gomez
2025-05-19 16:21 ` [PATCH v2 4/4] bootlinux: Fold bootlinux-local into the bootlinux role cel
2025-05-20 20:41   ` Daniel Gomez
2025-05-20 18:28 ` [PATCH v2 0/4] Remove the bootlinux-local role Daniel Gomez
2025-05-20 20:47   ` Daniel Gomez
2025-05-20 20:52     ` Chuck Lever
2025-05-21  7:42       ` Daniel Gomez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250519162131.381359-3-cel@kernel.org \
    --to=cel@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=da.gomez@kernel.org \
    --cc=kdevops@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox