From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C27928313B for ; Mon, 19 May 2025 16:21:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747671695; cv=none; b=rDzGQy3x1J22BR5rdzhBRJms40wnr204xR/xcugcEgJHPOl9KMzo9BTBWGdE/w2GNoTrV289Yc4+3gI+SNQ177GLoEzFNcGJwh62idk6OBbxQCaS1R5NckuNlK8p859VfI1oAzXsliCaf6Wnf8JiisGWZriBpuXiAD7fJAE0r1c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747671695; c=relaxed/simple; bh=Rkvuo0jYXmbOtuq0wif7AZDxuYawmdGeBsZhlqodUHQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LgU407z1FzzfskofUJx9Tq7ijbzvWMBcM/YzcVNDcABr3URGkTiaRLzG6/zVyb2hcAe6ov4ayhcSfzkZgWhStVSmj3c1+gpxMZQu0ZvoWWk7/aQLqlAwPDcLM0bVtiOJUsk0Zi7Wyg39rHcWCbwzZkEYypwLsVLi7NP6uYmzuc4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=joCbMrMv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="joCbMrMv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8EC10C4CEE4; Mon, 19 May 2025 16:21:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747671694; bh=Rkvuo0jYXmbOtuq0wif7AZDxuYawmdGeBsZhlqodUHQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=joCbMrMvKl44QhPJenKhK9yw6t92FPvXVsgBstjWzMYxNyq8wlkK6pGGJjIsvy4OE 3pq8XlchbzVySZI2e8fAQa79PCher1JI+UjUkVP4jjI4QNeI7ox2Z/mn0kRCG5ewsz zK6ufkKfLae0SC8XaMh/IX4rTx4mvLxRZSHp5dS/CnHItgDLxzT05LRRMoQQ8M0Pwb 4fMpcD7WVKG4lrCr5m8XMoTNCE0rKAY0XKxRfOtWlhXhmebVvslOtO4yshiD3Kl1Vl 32BHOkm1lhbeN0bp7o4+g8JkkPkX2f8K59xFrQQ8JJf++MX4/dbso1NIaTKh8ASt+N b6CkxxI2BKmsQ== From: cel@kernel.org To: Cc: Daniel Gomez , Chuck Lever Subject: [PATCH v2 2/4] bootlinux: Modernize install-deps/main.yml Date: Mon, 19 May 2025 12:21:29 -0400 Message-ID: <20250519162131.381359-3-cel@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250519162131.381359-1-cel@kernel.org> References: <20250519162131.381359-1-cel@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chuck Lever Clean-up: Address ansible-lint complaints: fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). playbooks/roles/bootlinux/tasks/install-deps/main.yml:2 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. name[casing]: All names should start with an uppercase letter. playbooks/roles/bootlinux/tasks/install-deps/main.yml:2 Task/Handler: oscheck distribution ospecific setup fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). playbooks/roles/bootlinux/tasks/install-deps/main.yml:5 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. name[missing]: All tasks should be named. playbooks/roles/bootlinux/tasks/install-deps/main.yml:5 Task/Handler: import_tasks suse/main.yml fqcn[action-core]: Use FQCN for builtin module actions (import_tasks). playbooks/roles/bootlinux/tasks/install-deps/main.yml:7 Use `ansible.builtin.import_tasks` or `ansible.legacy.import_tasks` instead. name[missing]: All tasks should be named. playbooks/roles/bootlinux/tasks/install-deps/main.yml:7 Task/Handler: import_tasks redhat/main.yml Signed-off-by: Chuck Lever --- .../bootlinux/tasks/install-deps/main.yml | 21 ++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/playbooks/roles/bootlinux/tasks/install-deps/main.yml b/playbooks/roles/bootlinux/tasks/install-deps/main.yml index c4c16d20509c..51a207416ad3 100644 --- a/playbooks/roles/bootlinux/tasks/install-deps/main.yml +++ b/playbooks/roles/bootlinux/tasks/install-deps/main.yml @@ -1,8 +1,15 @@ --- -- name: oscheck distribution ospecific setup - import_tasks: debian/main.yml - when: ansible_facts['os_family']|lower == 'debian' -- import_tasks: suse/main.yml - when: ansible_facts['os_family']|lower == 'suse' -- import_tasks: redhat/main.yml - when: ansible_facts['os_family']|lower == 'redhat' +- name: Debian-specific setup + ansible.builtin.import_tasks: debian/main.yml + when: + - ansible_os_family == "Debian" + +- name: SuSE-specific setup + ansible.builtin.import_tasks: suse/main.yml + when: + - ansible_os_family == "Suse" + +- name: Red Hat-specific setup + ansible.builtin.import_tasks: redhat/main.yml + when: + - ansible_os_family == "RedHat" -- 2.49.0