public inbox for kdevops@lists.linux.dev
 help / color / mirror / Atom feed
From: cel@kernel.org
To: <kdevops@lists.linux.dev>
Cc: Daniel Gomez <da.gomez@kernel.org>, Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH v2 3/4] bootlinux: Switch to import_tasks for install-deps
Date: Mon, 19 May 2025 12:21:30 -0400	[thread overview]
Message-ID: <20250519162131.381359-4-cel@kernel.org> (raw)
In-Reply-To: <20250519162131.381359-1-cel@kernel.org>

From: Chuck Lever <chuck.lever@oracle.com>

The bootlinux role includes install-deps/main.yml, but
install-deps/main.yml imports the distribution-specific tasks. It's
better to avoid mixing import_tasks and include_tasks:

https://docs.ansible.com/ansible/2.9/user_guide/playbooks_reuse_includes.html#including-and-importing-task-files

Switch bootlinux/tasks/main.yml to use import_tasks.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 playbooks/roles/bootlinux/tasks/main.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/playbooks/roles/bootlinux/tasks/main.yml b/playbooks/roles/bootlinux/tasks/main.yml
index cb98ab3077e8..ab647d9862a8 100644
--- a/playbooks/roles/bootlinux/tasks/main.yml
+++ b/playbooks/roles/bootlinux/tasks/main.yml
@@ -11,8 +11,8 @@
   tags: vars
 
 # Distro specific
-- name: Install dependencies
-  include_tasks:
+- name: Install dependencies to build and install the Linux kernel
+  ansible.builtin.import_tasks:
     file: install-deps/main.yml
 
 # We do this regardless of what distro you use
-- 
2.49.0


  parent reply	other threads:[~2025-05-19 16:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-19 16:21 [PATCH v2 0/4] Remove the bootlinux-local role cel
2025-05-19 16:21 ` [PATCH v2 1/4] bootlinux: Remove the 'linux' tag cel
2025-05-20 20:43   ` Daniel Gomez
2025-05-19 16:21 ` [PATCH v2 2/4] bootlinux: Modernize install-deps/main.yml cel
2025-05-20 18:27   ` Daniel Gomez
2025-05-19 16:21 ` cel [this message]
2025-05-20 20:33   ` [PATCH v2 3/4] bootlinux: Switch to import_tasks for install-deps Daniel Gomez
2025-05-19 16:21 ` [PATCH v2 4/4] bootlinux: Fold bootlinux-local into the bootlinux role cel
2025-05-20 20:41   ` Daniel Gomez
2025-05-20 18:28 ` [PATCH v2 0/4] Remove the bootlinux-local role Daniel Gomez
2025-05-20 20:47   ` Daniel Gomez
2025-05-20 20:52     ` Chuck Lever
2025-05-21  7:42       ` Daniel Gomez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250519162131.381359-4-cel@kernel.org \
    --to=cel@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=da.gomez@kernel.org \
    --cc=kdevops@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox