From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F8D828313B for ; Mon, 19 May 2025 16:21:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747671695; cv=none; b=QwZzCUsY02uJ+QbGnf9Fo1qKsx7QkoMumPiiCqF/7KugywYErz2HvnEIkMu3QKOLl03E4j6+VaIgJ7P4QMB5mw749wH9aA0zJQ0shCL3WQODzm+v5FhZlPEga250mIiYrcSxcXDO9ZvOZS65JbUx0kko/QBJPgmpTaIhSehuuac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747671695; c=relaxed/simple; bh=0TC/Ng22GzKvAyWRqcUhCME6QMe8D9UF/41nuMMjoAI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SppwWH3hK7b9B/qCdsOgECqu/hnsrweLv0UkwPSwCHqWTTSPzr9lnj5gEazes/QM7lVx0RzrfdSZJgBY9pyOo5fVAhnJb/QgEmqiauVApo/PVbHrdva38kxuXCCxe3bkWs9hBVQxaIBTblfyPS8KhBzaEiHgJH0DWlSL665sLDI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LmjjQ4gN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LmjjQ4gN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13E57C4CEF1; Mon, 19 May 2025 16:21:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747671695; bh=0TC/Ng22GzKvAyWRqcUhCME6QMe8D9UF/41nuMMjoAI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LmjjQ4gNTH+aVlRdqsoXKf5ciAtQI4OqGAMZ3t5p6dWmNC0Yn9HTuTsjK5uUw9ch6 YXX1Pkv7LA7DKihVUlr6Nl70Y5dTvulOxtb+2XpiBbG9EqjfmMyWvOteACBYbt+rYH h4snARFUGLBj+uZD85QqJgCUTw1/m8TwpgQK/luLKndB0ExbGvo46O0zWYjqoL0kAF MzReJcZ8/9ZNZLclDF4Ki9xdfMAagqWYtJo2Yvd5H16hxqLJKFxbmQ0Gk8rQ+KcXlf FZJmUDnijnyiJIEbd12qLQqpyJYpNyTR5MLZ7FXZGomaP5EtuZKkxfyaG1ib9PJTjE uiWAxAz3eJPFg== From: cel@kernel.org To: Cc: Daniel Gomez , Chuck Lever Subject: [PATCH v2 3/4] bootlinux: Switch to import_tasks for install-deps Date: Mon, 19 May 2025 12:21:30 -0400 Message-ID: <20250519162131.381359-4-cel@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250519162131.381359-1-cel@kernel.org> References: <20250519162131.381359-1-cel@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chuck Lever The bootlinux role includes install-deps/main.yml, but install-deps/main.yml imports the distribution-specific tasks. It's better to avoid mixing import_tasks and include_tasks: https://docs.ansible.com/ansible/2.9/user_guide/playbooks_reuse_includes.html#including-and-importing-task-files Switch bootlinux/tasks/main.yml to use import_tasks. Signed-off-by: Chuck Lever --- playbooks/roles/bootlinux/tasks/main.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/playbooks/roles/bootlinux/tasks/main.yml b/playbooks/roles/bootlinux/tasks/main.yml index cb98ab3077e8..ab647d9862a8 100644 --- a/playbooks/roles/bootlinux/tasks/main.yml +++ b/playbooks/roles/bootlinux/tasks/main.yml @@ -11,8 +11,8 @@ tags: vars # Distro specific -- name: Install dependencies - include_tasks: +- name: Install dependencies to build and install the Linux kernel + ansible.builtin.import_tasks: file: install-deps/main.yml # We do this regardless of what distro you use -- 2.49.0