public inbox for kdevops@lists.linux.dev
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Chuck Lever <cel@kernel.org>, Daniel Gomez <da.gomez@kruces.com>,
	Viacheslav Dubeyko <slava@dubeyko.com>,
	kdevops@lists.linux.dev
Cc: Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 0/4] steady-state: few fixes for steady state support
Date: Thu, 17 Jul 2025 21:05:52 -0700	[thread overview]
Message-ID: <20250718040557.2774976-1-mcgrof@kernel.org> (raw)

Here are some fixes on top of what ChatGPT Codex generated. It shows
why it gets only a grade of B. I've now tested this code on bare metal and
confirm it works. Future work generated by AI won't be merged directly but more
heavily tested and vetted. We essentially need to tell the bots to test
new workflows too. It would have caught some of the minor issues like
these.

The conversion of scripts/workflows/precondition/prefill-fio-jobs.sh was
a bit more difficult so although the an AI did that conversion I did
have to carefully vet it.

I did try to revert all the work and merge this patch on top as a clean
single patch but that actually ended up being a mess. Oh well. The next
patch will be a better example new workflow model of a patch we can tell
generative AIs to use as a good example of a new workflow to base its
work on.

This goes tested against bare metal. I just created the host file myself.

Luis Chamberlain (4):
  steady-state: use extra sparse drives when on libvirt
  steady-state: fix identation on Makefile
  steady-state: remove extra menu
  steady-state: quite a bit of fixes

 .../roles/steady_state/defaults/main.yml      |  37 +-
 playbooks/roles/steady_state/tasks/main.yaml  | 314 +++++++++++++-
 .../roles/steady_state/templates/ss_bw.ini.j2 |  22 +-
 .../steady_state/templates/ss_iops.ini.j2     |  22 +-
 .../precondition/prefill-fio-jobs.sh          | 390 ------------------
 workflows/steady_state/Kconfig                |  83 +++-
 workflows/steady_state/Makefile               |  34 +-
 7 files changed, 454 insertions(+), 448 deletions(-)
 delete mode 100755 scripts/workflows/precondition/prefill-fio-jobs.sh

-- 
2.47.2


             reply	other threads:[~2025-07-18  4:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-18  4:05 Luis Chamberlain [this message]
2025-07-18  4:05 ` [PATCH 1/4] steady-state: use extra sparse drives when on libvirt Luis Chamberlain
2025-07-18  4:05 ` [PATCH 2/4] steady-state: fix identation on Makefile Luis Chamberlain
2025-07-18  4:05 ` [PATCH 3/4] steady-state: remove extra menu Luis Chamberlain
2025-07-18  4:05 ` [PATCH 4/4] steady-state: quite a bit of fixes Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250718040557.2774976-1-mcgrof@kernel.org \
    --to=mcgrof@kernel.org \
    --cc=cel@kernel.org \
    --cc=da.gomez@kruces.com \
    --cc=kdevops@lists.linux.dev \
    --cc=slava@dubeyko.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox