From: Luis Chamberlain <mcgrof@kernel.org>
To: Chuck Lever <cel@kernel.org>, Daniel Gomez <da.gomez@kruces.com>,
kdevops@lists.linux.dev
Cc: Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 3/4] gen_nodes/gen_hosts: avoid usage of fs_config_path on task names
Date: Fri, 25 Jul 2025 18:16:51 -0700 [thread overview]
Message-ID: <20250726011653.2622672-4-mcgrof@kernel.org> (raw)
In-Reply-To: <20250726011653.2622672-1-mcgrof@kernel.org>
The variable fs_config_path is not defined when we don't enable
fstests and so we'll get a warning about it not being defined.
Fix this by not using it on task names.
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
playbooks/roles/gen_hosts/tasks/main.yml | 4 ++--
playbooks/roles/gen_nodes/tasks/main.yml | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/playbooks/roles/gen_hosts/tasks/main.yml b/playbooks/roles/gen_hosts/tasks/main.yml
index 58ebd1d..c10abc5 100644
--- a/playbooks/roles/gen_hosts/tasks/main.yml
+++ b/playbooks/roles/gen_hosts/tasks/main.yml
@@ -49,12 +49,12 @@
- ansible_hosts_template.stat.exists
tags: vars
-- name: Verify fstest config file file exists {{ fs_config_path }}
+- name: Verify fstest config file exists
stat:
path: "{{ fs_config_path }}"
register: fstests_config_file_reg
when:
- - is_fstests
+ - is_fstests|bool
- name: Generate the Ansible hosts file
tags: [ 'hosts' ]
diff --git a/playbooks/roles/gen_nodes/tasks/main.yml b/playbooks/roles/gen_nodes/tasks/main.yml
index ebaba92..cb8459a 100644
--- a/playbooks/roles/gen_nodes/tasks/main.yml
+++ b/playbooks/roles/gen_nodes/tasks/main.yml
@@ -101,7 +101,7 @@
- ansible_nodes_template.stat.exists
tags: vars
-- name: Verify fstest config file file exists {{ fs_config_path }}
+- name: Verify fstest config file exists
stat:
path: "{{ fs_config_path }}"
register: fstests_config_file_reg
--
2.47.2
next prev parent reply other threads:[~2025-07-26 1:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-26 1:16 [PATCH 0/4] kdevops: add support for A/B testing Luis Chamberlain
2025-07-26 1:16 ` [PATCH 1/4] Makefile: add make style for style checking Luis Chamberlain
2025-07-26 1:16 ` [PATCH 2/4] CLAUDE.md: new workflow guide for hosts and nodes Luis Chamberlain
2025-07-26 1:16 ` Luis Chamberlain [this message]
2025-07-26 1:16 ` [PATCH 4/4] bootlinux: add support for A/B kernel testing Luis Chamberlain
2025-07-26 18:00 ` Chuck Lever
2025-07-26 20:21 ` Luis Chamberlain
2025-07-26 21:37 ` Luis Chamberlain
2025-07-26 22:46 ` Luis Chamberlain
2025-07-26 23:16 ` Chuck Lever
2025-07-26 23:34 ` Luis Chamberlain
2025-07-26 23:35 ` Chuck Lever
2025-07-27 0:06 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250726011653.2622672-4-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=cel@kernel.org \
--cc=da.gomez@kruces.com \
--cc=kdevops@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox