From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C011019992C for ; Sat, 26 Jul 2025 01:16:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753492616; cv=none; b=ir0Uo/osJSYTArbUB9kMygk+VHzwVUeShQaG82sJMgn04Xerr6MIfiDh4avVxBM0h9clJpfPdqci1unr9MXpNHY5UfodRt4GryIgtCM3Cu3596nqtvC6EhwrPVd8eQ8l3IH2HB2YHIhIoEuW1P3tdE3YbMDR3OjIaLGTFqmCmWs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753492616; c=relaxed/simple; bh=+UtQjOxnTMurrYElerxSwJwV0j1CUSrD2JGEomsc8K8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uK9rkMVNexoUtsurn+Q2jyjSJ8ELKIcRSpexr285y6ReN9zh1VoZP+Mm1fzNSa4DvD4ANVkJIB/dMA1qLukJGDgEcyK3e7lMjEr8W/UGEM2rugrS3PNFqhZQKIqh8cfpsYZ69pZoOlNRAtSUT26Muv4VA2NJGYSpFCW5jg6myXE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=RXLMTJcb; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="RXLMTJcb" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=fpgBU3ROHoHNTlBUoDnLzpu9gmcEyRpYBUjLyzt7/5c=; b=RXLMTJcb3INgsct5ztRP+/WmRk pHN/8o4vT4fj+Cu33Bz1PDNZSGnl5TwBokMYzf7W1P29s9IBICq9/MIsb4fihePfW/5NM8bl3NMhi z76enpvNLiQaIj8uA6FDP2yXev/6yJ5V7mD/sbaF+TJBuQiysWkF2qKJ/E2YQUA65Fs9DAa6GuVho 0fjOIX1BDJQifJrQSF0bu5/wfhKxKP1K26VAXVODJSEQplJ6c+U0NdH+mTZx8nFGpPnLWEKaPQsxS t36gotYqQPf7Xo1om5OE+L5+HRi2HU4PcObc6KdK/wtgsCAltQgAADjQLixBqgmgV9eocOHdL/Vo/ Di5m7Uuw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1ufTWw-0000000B0HO-1Po0; Sat, 26 Jul 2025 01:16:54 +0000 From: Luis Chamberlain To: Chuck Lever , Daniel Gomez , kdevops@lists.linux.dev Cc: Luis Chamberlain Subject: [PATCH 3/4] gen_nodes/gen_hosts: avoid usage of fs_config_path on task names Date: Fri, 25 Jul 2025 18:16:51 -0700 Message-ID: <20250726011653.2622672-4-mcgrof@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250726011653.2622672-1-mcgrof@kernel.org> References: <20250726011653.2622672-1-mcgrof@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Luis Chamberlain The variable fs_config_path is not defined when we don't enable fstests and so we'll get a warning about it not being defined. Fix this by not using it on task names. Signed-off-by: Luis Chamberlain --- playbooks/roles/gen_hosts/tasks/main.yml | 4 ++-- playbooks/roles/gen_nodes/tasks/main.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/playbooks/roles/gen_hosts/tasks/main.yml b/playbooks/roles/gen_hosts/tasks/main.yml index 58ebd1d..c10abc5 100644 --- a/playbooks/roles/gen_hosts/tasks/main.yml +++ b/playbooks/roles/gen_hosts/tasks/main.yml @@ -49,12 +49,12 @@ - ansible_hosts_template.stat.exists tags: vars -- name: Verify fstest config file file exists {{ fs_config_path }} +- name: Verify fstest config file exists stat: path: "{{ fs_config_path }}" register: fstests_config_file_reg when: - - is_fstests + - is_fstests|bool - name: Generate the Ansible hosts file tags: [ 'hosts' ] diff --git a/playbooks/roles/gen_nodes/tasks/main.yml b/playbooks/roles/gen_nodes/tasks/main.yml index ebaba92..cb8459a 100644 --- a/playbooks/roles/gen_nodes/tasks/main.yml +++ b/playbooks/roles/gen_nodes/tasks/main.yml @@ -101,7 +101,7 @@ - ansible_nodes_template.stat.exists tags: vars -- name: Verify fstest config file file exists {{ fs_config_path }} +- name: Verify fstest config file exists stat: path: "{{ fs_config_path }}" register: fstests_config_file_reg -- 2.47.2