From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 785D672636 for ; Mon, 28 Jul 2025 00:18:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753661888; cv=none; b=RSq0lmz25vvJ/KbSA/aWc59kWfyvqM6fuf5oW03ScBjz4BAbEjmWyZQtuxZFz/0/y4+uQA82RaFP/mnJNUIA+LJiLtfCDd7J20kUMpGg0atB3I91/vBISEJPPCpZqwgoDBzvk1/r3gUEoNPzU1bbeaavPRSNUvlsFSEmfbIHPxE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753661888; c=relaxed/simple; bh=JSjMV33BFc4U0y+huGSPfWJ87Nz1sQM5TjSoqUEoxNY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HIjpa1gZO5jQAyPiOwcO6w1uHttPYIvdAduFpLnV/oqr8KI915MflkEa9wEfXw0CMapP5RGUCxAH3OYQlqjJQixmzojjlUWB0zsub/MNZe/sOOzMTrm3cOldWULiFH5VAZNKOroNz+GEJzjzrcvxYb2KRRcrkUFZNya/LSHrJlA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=A+JkgWZq; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="A+JkgWZq" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=qA95YjLv4oxsxFE9Ud1kPtRsm3CLQo4rBBRIDjKKwqc=; b=A+JkgWZqwAH5lUYoy4NiwDAtQP 2RgwDuA9oZ4kYAt/U6otUrgklL/9tnV0hg/eQkHeo+XebW076BsoX1cfQpu8bmzqSp44rai429OkH 13YCzuS6tJ5l5NUiSd/tCNfCYfXn+Zaz1+o0pAEYA7MbprHFxvdBneC8gNzcvgYoaKKqj+Qpk3l4n xXaKoLxH2j2abMnhuQd35BJKjud5Y5OqLUji4Q74XV26M6TjvtMoAWX0zjq2EKYXE5/eOiEl8/a7z xqh3SwPHqHVB8U6wDV7QbJS8/HxWNbPjtkQZc2DLroo82+UY6bfSoiKV1FaKzt2PLayzj5OCBDDHl 00LTqfZQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1ugBZ5-0000000DNZI-35LV; Mon, 28 Jul 2025 00:18:03 +0000 From: Luis Chamberlain To: Chuck Lever , Daniel Gomez , kdevops@lists.linux.dev Cc: Luis Chamberlain Subject: [PATCH 40/40] gen_nodes/gen_hosts: avoid usage of fs_config_path on task names Date: Sun, 27 Jul 2025 17:17:59 -0700 Message-ID: <20250728001800.3188617-41-mcgrof@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250728001800.3188617-1-mcgrof@kernel.org> References: <20250728001800.3188617-1-mcgrof@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Luis Chamberlain The variable fs_config_path is not defined when we don't enable fstests and so we'll get a warning about it not being defined. Fix this by not using it on task names. Signed-off-by: Luis Chamberlain --- playbooks/roles/gen_hosts/tasks/main.yml | 4 ++-- playbooks/roles/gen_nodes/tasks/main.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/playbooks/roles/gen_hosts/tasks/main.yml b/playbooks/roles/gen_hosts/tasks/main.yml index 70d543ad..a60da620 100644 --- a/playbooks/roles/gen_hosts/tasks/main.yml +++ b/playbooks/roles/gen_hosts/tasks/main.yml @@ -49,12 +49,12 @@ - ansible_hosts_template.stat.exists tags: vars -- name: Verify fstest config file file exists {{ fs_config_path }} +- name: Verify fstest config file exists stat: path: "{{ fs_config_path }}" register: fstests_config_file_reg when: - - is_fstests + - is_fstests|bool - name: Generate the Ansible hosts file for a Linux kernel build tags: [ 'hosts' ] diff --git a/playbooks/roles/gen_nodes/tasks/main.yml b/playbooks/roles/gen_nodes/tasks/main.yml index ae017ee8..4192ae89 100644 --- a/playbooks/roles/gen_nodes/tasks/main.yml +++ b/playbooks/roles/gen_nodes/tasks/main.yml @@ -109,7 +109,7 @@ - ansible_nodes_template.stat.exists tags: vars -- name: Verify fstest config file file exists {{ fs_config_path }} +- name: Verify fstest config file exists stat: path: "{{ fs_config_path }}" register: fstests_config_file_reg -- 2.47.2