[PATCH v2 11/33] terraform: Move "wait_for_connection" out of the terraform playbook

[Luis Chamberlain <mcgrof@kernel.org>]

From: Chuck Lever <chuck.lever@oracle.com>

Refactor: The "wait_for_connection" task is the only one in the
terraform playbook that targets all hosts. The other tasks are all
done on the localhost.

Subsequent patches will replace "delegate_to: localhost" with the
usual role-wide setting.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 playbooks/roles/terraform/tasks/main.yml | 6 ------
 scripts/terraform.Makefile               | 1 +
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/playbooks/roles/terraform/tasks/main.yml b/playbooks/roles/terraform/tasks/main.yml
index 942efb7e..b50b417d 100644
--- a/playbooks/roles/terraform/tasks/main.yml
+++ b/playbooks/roles/terraform/tasks/main.yml
@@ -45,12 +45,6 @@
   tags:
     - ssh
 
-- name: Wait for target nodes to become reachable
-  ansible.builtin.wait_for_connection:
-    timeout: 60
-  tags:
-    - ssh
-
 - name: Remove the ephemeral ssh config file on the control host
   ansible.builtin.file:
     path: "{{ kdevops_ssh_config }}"
diff --git a/scripts/terraform.Makefile b/scripts/terraform.Makefile
index 91106b5b..f2f6fe0a 100644
--- a/scripts/terraform.Makefile
+++ b/scripts/terraform.Makefile
@@ -110,6 +110,7 @@ $(KDEVOPS_PROVISIONED_SSH):
 		-i $(KDEVOPS_HOSTFILE) \
 		playbooks/terraform.yml --tags ssh \
 		--extra-vars=@./extra_vars.yaml
+	$(Q)ansible $(ANSIBLE_VERBOSE) -i hosts all -m wait_for_connection
 	$(Q)touch $(KDEVOPS_PROVISIONED_SSH)
 
 status_terraform:
-- 
2.47.2