From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D3A117A2F8 for ; Mon, 28 Jul 2025 01:14:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753665282; cv=none; b=oC24X6G9ed1Z94qflADDiBDmoU+jrgsq0U2SfbHdbrRaCxlyn7KEIdjnoa3D763WpgXAUS0jFCmoUJ2Ss++nOAKnoCVRMIDkZgCCgbA3sS2NgivRl3clxCEC8P1dZnAeU8KVeiE74WWwzUl0YmZNJHl/Ras4lkX4riYiOCOzs+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753665282; c=relaxed/simple; bh=8RQaZpQrXR+ITFDod/zCzkZmWiOA0wBekya1vR5ZE68=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=u3orh9ISYAcdiRr1HtjY1ZpHbZ8CWN5SJjfHlAFP++3YVxoa0Uf4A9sjOe0oucVH6lKS7aNKLl9a9HqmoofnU3dmzpAM1GcETXuMS9b+8as09SBYH8so1KM93pxRWUzLgGPtA1q2IptH8Dq3ZbrlgrftStM3QI0epzmnAxfen+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=t7kPZlxI; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="t7kPZlxI" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=u6Z2vXfDQ+MHvfcreaCY+IcJZjmADp2XFJemajZc0io=; b=t7kPZlxIDnb0rdNFPlPpJLxMUF aDetcCAYECUVAyPpnGAQF9vowkE5wiiSybW0RyqUwjbfuO4psahFJD3IZUYAbW8XEPVLMCoh1uSMb 8QqarOR1+CkOFMffcEP2R5pgdLmzbFVe1JNz2kZehJPHV5WsXPFecIR4uUiOPVq4SOeG79wn+Tf4e SnxIjahdlQViqWqba+8WRUOOopkqp3925PVCpIs/JdNl+gl4tC76ONc5iodX82wTTH0gVQ4R++Vma 4lkNO4GgBRxbF7duKC5lXTz3y1nvjaCeCwdV35SKCn+ddBP+Ih7tzOtgoNLmzmD3QhqhFIUuY2Wlz c5w8G8dg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1ugCRn-0000000DPjV-3hbp; Mon, 28 Jul 2025 01:14:35 +0000 From: Luis Chamberlain To: Chuck Lever , Daniel Gomez , kdevops@lists.linux.dev Cc: Chuck Lever Subject: [PATCH v2 11/33] terraform: Move "wait_for_connection" out of the terraform playbook Date: Sun, 27 Jul 2025 18:14:11 -0700 Message-ID: <20250728011434.3197091-12-mcgrof@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250728011434.3197091-1-mcgrof@kernel.org> References: <20250728011434.3197091-1-mcgrof@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Luis Chamberlain From: Chuck Lever Refactor: The "wait_for_connection" task is the only one in the terraform playbook that targets all hosts. The other tasks are all done on the localhost. Subsequent patches will replace "delegate_to: localhost" with the usual role-wide setting. Signed-off-by: Chuck Lever --- playbooks/roles/terraform/tasks/main.yml | 6 ------ scripts/terraform.Makefile | 1 + 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/playbooks/roles/terraform/tasks/main.yml b/playbooks/roles/terraform/tasks/main.yml index 942efb7e..b50b417d 100644 --- a/playbooks/roles/terraform/tasks/main.yml +++ b/playbooks/roles/terraform/tasks/main.yml @@ -45,12 +45,6 @@ tags: - ssh -- name: Wait for target nodes to become reachable - ansible.builtin.wait_for_connection: - timeout: 60 - tags: - - ssh - - name: Remove the ephemeral ssh config file on the control host ansible.builtin.file: path: "{{ kdevops_ssh_config }}" diff --git a/scripts/terraform.Makefile b/scripts/terraform.Makefile index 91106b5b..f2f6fe0a 100644 --- a/scripts/terraform.Makefile +++ b/scripts/terraform.Makefile @@ -110,6 +110,7 @@ $(KDEVOPS_PROVISIONED_SSH): -i $(KDEVOPS_HOSTFILE) \ playbooks/terraform.yml --tags ssh \ --extra-vars=@./extra_vars.yaml + $(Q)ansible $(ANSIBLE_VERBOSE) -i hosts all -m wait_for_connection $(Q)touch $(KDEVOPS_PROVISIONED_SSH) status_terraform: -- 2.47.2