[PATCH v2 16/33] bootlinux: Relocate tasks that select a kernel .config

[Luis Chamberlain <mcgrof@kernel.org>]

From: Chuck Lever <chuck.lever@oracle.com>

Move the tasks that select the kernel .config to build into a
subrole. A dynamic "include_tasks" is used so that eventually these
tasks can be completely skipped when the bootlinux playbook is asked
only to install kernel packages.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 playbooks/roles/bootlinux/tasks/config.yml | 89 +++++++++++++++++++++
 playbooks/roles/bootlinux/tasks/main.yml   | 91 +---------------------
 2 files changed, 92 insertions(+), 88 deletions(-)
 create mode 100644 playbooks/roles/bootlinux/tasks/config.yml

diff --git a/playbooks/roles/bootlinux/tasks/config.yml b/playbooks/roles/bootlinux/tasks/config.yml
new file mode 100644
index 00000000..5cf03e7f
--- /dev/null
+++ b/playbooks/roles/bootlinux/tasks/config.yml
@@ -0,0 +1,89 @@
+---
+- name: Check whether config-kdevops exists
+  stat:
+    path: "{{ role_path }}/templates/config-kdevops"
+  register: config_kdevops
+  delegate_to: localhost
+
+- name: Found config-kdevops, using it for template
+  set_fact:
+    linux_config: "config-kdevops"
+  when: config_kdevops.stat.exists
+
+- name: No config-kdevops, looking for {{ target_linux_config }}
+  set_fact:
+    linux_config: "{{ target_linux_config }}"
+  when: not config_kdevops.stat.exists
+
+- name: Check if specific kernel config exists for {{ target_linux_ref }}
+  stat:
+    path: "{{ role_path }}/templates/{{ target_linux_config }}"
+  register: kernel_config
+  delegate_to: localhost
+
+- name: Find all linux-next configs if a your custom config-kdevops and ref config was not found
+  find:
+    paths: "{{ role_path }}/templates"
+    patterns: "config-next*"
+    file_type: file
+    recurse: no
+  register: found_configs
+  delegate_to: localhost
+  when:
+    - not config_kdevops.stat.exists
+    - not kernel_config.stat.exists
+
+- name: Extract the date from the filenames
+  set_fact:
+    configs_with_dates: "{{ configs_with_dates | default([]) + [{'file': item.path, 'date': (item.path | regex_search('config-next-(\\d{8})')).split('-')[-1]}] }}"
+  loop: "{{ found_configs.files }}"
+  when:
+    - not config_kdevops.stat.exists
+    - not kernel_config.stat.exists
+    - item.path is search('config-next-(\\d{8})')
+  no_log: true
+  delegate_to: localhost
+
+- name: Sort configs based on date extracted from filename
+  set_fact:
+    sorted_configs: "{{ configs_with_dates | selectattr('date', 'defined') | sort(attribute='date', reverse=True) | map(attribute='file') | list }}"
+  when:
+    - not config_kdevops.stat.exists
+    - not kernel_config.stat.exists
+    - configs_with_dates | length > 0
+  delegate_to: localhost
+
+- name: Set latest linux-next config if configs are found
+  set_fact:
+    latest_linux_next_config: "{{ sorted_configs[0] }}"
+  when:
+    - not config_kdevops.stat.exists and not kernel_config.stat.exists
+    - sorted_configs | length > 0
+  delegate_to: localhost
+
+- name: Use the specific kernel config or fallback to the latest linux-next
+  set_fact:
+    linux_config: "{{ target_linux_config | default('') if kernel_config.stat.exists else (latest_linux_next_config | default('') | basename) }}"
+  when:
+    - not config_kdevops.stat.exists
+    - not kernel_config.stat.exists
+    - latest_linux_next_config is defined
+  delegate_to: localhost
+
+- name: Verify config used
+  debug:
+    msg: "Linux config used: {{ role_path }}/templates/{{ linux_config }}"
+  delegate_to: localhost
+
+- name: Verify that the Linux configuration file exists
+  stat:
+    path: "{{ role_path }}/templates/{{ linux_config }}"
+  register: config_stat
+  delegate_to: localhost
+  when: linux_config is defined
+
+- name: Fail if the configuration file does not exist
+  fail:
+    msg: "The configuration file {{ role_path }}/templates/{{ linux_config }} does not exist."
+  when: not config_stat.stat.exists
+  delegate_to: localhost
diff --git a/playbooks/roles/bootlinux/tasks/main.yml b/playbooks/roles/bootlinux/tasks/main.yml
index 7671389c..9c43c1e5 100644
--- a/playbooks/roles/bootlinux/tasks/main.yml
+++ b/playbooks/roles/bootlinux/tasks/main.yml
@@ -223,94 +223,9 @@
   run_once: true
   delegate_to: localhost
 
-- name: Check whether config-kdevops exists
-  stat:
-    path: "{{ role_path }}/templates/config-kdevops"
-  register: config_kdevops
-  delegate_to: localhost
-
-- name: Found config-kdevops, using it for template
-  set_fact:
-    linux_config: "config-kdevops"
-  when: config_kdevops.stat.exists
-
-- name: No config-kdevops, looking for {{ target_linux_config }}
-  set_fact:
-    linux_config: "{{ target_linux_config }}"
-  when: not config_kdevops.stat.exists
-
-- name: Check if specific kernel config exists for {{ target_linux_ref }}
-  stat:
-    path: "{{ role_path }}/templates/{{ target_linux_config }}"
-  register: kernel_config
-  delegate_to: localhost
-
-- name: Find all linux-next configs if a your custom config-kdevops and ref config was not found
-  find:
-    paths: "{{ role_path }}/templates"
-    patterns: "config-next*"
-    file_type: file
-    recurse: no
-  register: found_configs
-  delegate_to: localhost
-  when:
-    - not config_kdevops.stat.exists
-    - not kernel_config.stat.exists
-
-- name: Extract the date from the filenames
-  set_fact:
-    configs_with_dates: "{{ configs_with_dates | default([]) + [{'file': item.path, 'date': (item.path | regex_search('config-next-(\\d{8})')).split('-')[-1]}] }}"
-  loop: "{{ found_configs.files }}"
-  when:
-    - not config_kdevops.stat.exists
-    - not kernel_config.stat.exists
-    - item.path is search('config-next-(\\d{8})')
-  no_log: true
-  delegate_to: localhost
-
-- name: Sort configs based on date extracted from filename
-  set_fact:
-    sorted_configs: "{{ configs_with_dates | selectattr('date', 'defined') | sort(attribute='date', reverse=True) | map(attribute='file') | list }}"
-  when:
-    - not config_kdevops.stat.exists
-    - not kernel_config.stat.exists
-    - configs_with_dates | length > 0
-  delegate_to: localhost
-
-- name: Set latest linux-next config if configs are found
-  set_fact:
-    latest_linux_next_config: "{{ sorted_configs[0] }}"
-  when:
-    - not config_kdevops.stat.exists and not kernel_config.stat.exists
-    - sorted_configs | length > 0
-  delegate_to: localhost
-
-- name: Use the specific kernel config or fallback to the latest linux-next
-  set_fact:
-    linux_config: "{{ target_linux_config | default('') if kernel_config.stat.exists else (latest_linux_next_config | default('') | basename) }}"
-  when:
-    - not config_kdevops.stat.exists
-    - not kernel_config.stat.exists
-    - latest_linux_next_config is defined
-  delegate_to: localhost
-
-- name: Verify config used
-  debug:
-    msg: "Linux config used: {{ role_path }}/templates/{{ linux_config }}"
-  delegate_to: localhost
-
-- name: Verify that the Linux configuration file exists
-  stat:
-    path: "{{ role_path }}/templates/{{ linux_config }}"
-  register: config_stat
-  delegate_to: localhost
-  when: linux_config is defined
-
-- name: Fail if the configuration file does not exist
-  fail:
-    msg: "The configuration file {{ role_path }}/templates/{{ linux_config }} does not exist."
-  when: not config_stat.stat.exists
-  delegate_to: localhost
+- name: Select the .config file for building the test kernel
+  ansible.builtin.include_tasks:
+    file: "{{ role_path }}/tasks/config.yml"
 
 - name: Copy configuration for Linux {{ target_linux_tree }} to the target nodes
   template:
-- 
2.47.2