[PATCH v2 21/33] bootlinux: Clean up a grub set-up task

[Luis Chamberlain <mcgrof@kernel.org>]

From: Chuck Lever <chuck.lever@oracle.com>

The "target_kernel" variable seems to be unused, so remove it.

Address several ansible-lint complaints:
 - command-instead-of-shell
 - fqcn[action-core]: Use FQCN for builtin module actions (shell).
 - jinja[spacing]: Jinja2 spacing could be improved
 - name[template]: Jinja templates should only be at the end of 'name'
 - no-changed-when
 - schema[tasks]: 'become_method' must be one of the currently available values
 - yaml[line-length]: Line too long (176 > 160 characters)
 - yaml[truthy]: Truthy value should be one of [false, true]
 - yaml[brackets]: Too many spaces inside brackets
 - fqcn[action-core]: Use FQCN for builtin module actions (set_fact).

Note: The preferred way to select a shell script and run it on a
managed system is to use the template module to copy the selected
script to each target host, and then use the Ansible scripts module
to run it. That could be for another day.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 .../bootlinux/tasks/update-grub/install.yml   | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/playbooks/roles/bootlinux/tasks/update-grub/install.yml b/playbooks/roles/bootlinux/tasks/update-grub/install.yml
index 907f0a18..8402c09b 100644
--- a/playbooks/roles/bootlinux/tasks/update-grub/install.yml
+++ b/playbooks/roles/bootlinux/tasks/update-grub/install.yml
@@ -131,16 +131,19 @@
 # is either you do the work to enhance the heuristic or live happy with the
 # assumption that grub2's default of picking the latest kernel is the best
 # option.
-- name: Try to find your target kernel's GRUB boot entry number now that the menu is flattened for {{ target_linux_ref }} using inferred KERNELRELEASE {{ kernelrelease.stdout}}
-  become: yes
+- name: Determine the target kernel's GRUB boot entry number
+  # noqa: command-instead-of-shell
+  tags:
+    - saved
+  become: true
   become_flags: 'su - -c'
-  become_method: sudo
-  shell: " {{ determine_default_kernel_id }} "
-  vars:
-    target_kernel: "{{ target_linux_ref | replace('v', '') }}"
+  become_method: ansible.builtin.sudo
+  ansible.builtin.shell:
+    cmd: "{{ determine_default_kernel_id }}"
   register: grub_boot_number_cmd
-  tags: [ 'saved' ]
-  when: kernel_release_file.stat.exists
+  changed_when: false
+  when:
+    - kernel_release_file.stat.exists
 
 - name: Obtain command to set default kernel to boot
   set_fact:
-- 
2.47.2