From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C79DB198E8C for ; Mon, 28 Jul 2025 01:14:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753665281; cv=none; b=TRPjXRxuVNykCdvaw8NbfZsvsrLGg44BklRj0V2A6KpRYJlKKC9B41g6R+peqmWQCCBlI7ykOTP8t79ercwSuMLlMfbjM6lx8XZL71VPDiEhaWJejAAXF8zQzzOUNpr0mD4U+JrIMumhVx09hWYUlyRqSyNaKKRfO39Uk26yr8E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753665281; c=relaxed/simple; bh=JSjMV33BFc4U0y+huGSPfWJ87Nz1sQM5TjSoqUEoxNY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ff59FYBeaEPX9JHiGzfG4vl0tYeqP3952nbCMn5UirfFjX98GQSCXoUECyPTo85rEsPfSbraTnVobrlXxq3LBKUXJkfJIEIsT2pYT5eCoudUOAb3/bJ2CiafB0weLDbH3evfJ39GLyAorCE0gJIxdd4gDFEJIoP/fJ8WTOKBcvo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=zJcZ9iWS; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="zJcZ9iWS" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=qA95YjLv4oxsxFE9Ud1kPtRsm3CLQo4rBBRIDjKKwqc=; b=zJcZ9iWSfmkECz4HPOmV8FNcoK wCe+UzGWcehwK2oPuG1CppnkYbF+4cwHghI2LuWrn4uw9ujQrUuJdtxbbAZoj1sxFXtRtEZazmIBG j/ZX5g+bMjDD3EfSbL7V1hLD+eRJmEOwgC1uTus2BWKLLwboQQX159snDnd8BO4g4rX7M6of3ozN9 XANeKoQM21n+sU01X9rke/BsiuNgdjOGPOf2ZnJabInTRthoLUPTLoSfXlDoxXwzWAADwHpNNcMtP 3eU4BDNXkM44p1fyblI1AFFUauZT4cjT7SUoI+rCmWgbc59rIMf2Rp55f7ar1xHxyu7rFTGd76ZZe 2xfBUQ3g==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1ugCRo-0000000DPlt-3WEV; Mon, 28 Jul 2025 01:14:36 +0000 From: Luis Chamberlain To: Chuck Lever , Daniel Gomez , kdevops@lists.linux.dev Cc: Luis Chamberlain Subject: [PATCH v2 33/33] gen_nodes/gen_hosts: avoid usage of fs_config_path on task names Date: Sun, 27 Jul 2025 18:14:33 -0700 Message-ID: <20250728011434.3197091-34-mcgrof@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250728011434.3197091-1-mcgrof@kernel.org> References: <20250728011434.3197091-1-mcgrof@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Luis Chamberlain The variable fs_config_path is not defined when we don't enable fstests and so we'll get a warning about it not being defined. Fix this by not using it on task names. Signed-off-by: Luis Chamberlain --- playbooks/roles/gen_hosts/tasks/main.yml | 4 ++-- playbooks/roles/gen_nodes/tasks/main.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/playbooks/roles/gen_hosts/tasks/main.yml b/playbooks/roles/gen_hosts/tasks/main.yml index 70d543ad..a60da620 100644 --- a/playbooks/roles/gen_hosts/tasks/main.yml +++ b/playbooks/roles/gen_hosts/tasks/main.yml @@ -49,12 +49,12 @@ - ansible_hosts_template.stat.exists tags: vars -- name: Verify fstest config file file exists {{ fs_config_path }} +- name: Verify fstest config file exists stat: path: "{{ fs_config_path }}" register: fstests_config_file_reg when: - - is_fstests + - is_fstests|bool - name: Generate the Ansible hosts file for a Linux kernel build tags: [ 'hosts' ] diff --git a/playbooks/roles/gen_nodes/tasks/main.yml b/playbooks/roles/gen_nodes/tasks/main.yml index ae017ee8..4192ae89 100644 --- a/playbooks/roles/gen_nodes/tasks/main.yml +++ b/playbooks/roles/gen_nodes/tasks/main.yml @@ -109,7 +109,7 @@ - ansible_nodes_template.stat.exists tags: vars -- name: Verify fstest config file file exists {{ fs_config_path }} +- name: Verify fstest config file exists stat: path: "{{ fs_config_path }}" register: fstests_config_file_reg -- 2.47.2