From: Luis Chamberlain <mcgrof@kernel.org>
To: Chuck Lever <cel@kernel.org>, Daniel Gomez <da.gomez@kruces.com>,
kdevops@lists.linux.dev
Cc: Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH v2 5/9] Makefile: move styling to scripts/style.Makefile
Date: Tue, 29 Jul 2025 23:01:41 -0700 [thread overview]
Message-ID: <20250730060147.182140-6-mcgrof@kernel.org> (raw)
In-Reply-To: <20250730060147.182140-1-mcgrof@kernel.org>
Monitoring styling enhancements turn out to be its own thing, move
this effort to its own file to keep the top level Makefile tidy.
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
Makefile | 13 +------------
scripts/style.Makefile | 12 ++++++++++++
2 files changed, 13 insertions(+), 12 deletions(-)
create mode 100644 scripts/style.Makefile
diff --git a/Makefile b/Makefile
index 2c72042d..c88637c2 100644
--- a/Makefile
+++ b/Makefile
@@ -246,18 +246,7 @@ include scripts/tests.Makefile
include scripts/ci.Makefile
include scripts/archive.Makefile
include scripts/defconfig.Makefile
-
-PHONY += fix-whitespace-last-commit
-fix-whitespace-last-commit:
- $(Q)git diff --name-only --diff-filter=M HEAD~1..HEAD | xargs -r python3 scripts/fix_whitespace_issues.py
-
-PHONY += style
-style:
- $(Q)if which black > /dev/null ; then black . || true; fi
- $(Q)python3 scripts/detect_whitespace_issues.py || true
- $(Q)python3 scripts/detect_indentation_issues.py || true
- $(Q)python3 scripts/check_commit_format.py || true
- $(Q)python3 scripts/ensure_newlines.py || true
+include scripts/style.Makefile
PHONY += clean
clean:
diff --git a/scripts/style.Makefile b/scripts/style.Makefile
new file mode 100644
index 00000000..2108eb4c
--- /dev/null
+++ b/scripts/style.Makefile
@@ -0,0 +1,12 @@
+PHONY += fix-whitespace-last-commit
+fix-whitespace-last-commit:
+ $(Q)git diff --name-only --diff-filter=M HEAD~1..HEAD | xargs -r python3 scripts/fix_whitespace_issues.py
+
+PHONY += style
+style:
+ $(Q)if which black > /dev/null ; then black . || true; fi
+ $(Q)python3 scripts/detect_whitespace_issues.py || true
+ $(Q)python3 scripts/detect_indentation_issues.py || true
+ $(Q)python3 scripts/check_commit_format.py || true
+ $(Q)python3 scripts/ensure_newlines.py || true
+
--
2.47.2
next prev parent reply other threads:[~2025-07-30 6:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 6:01 [PATCH v2 0/9] kdevops: add support for A/B testing Luis Chamberlain
2025-07-30 6:01 ` [PATCH v2 1/9] roles/guestfs: add missing bootlinux_9p: False Luis Chamberlain
2025-07-30 14:17 ` Chuck Lever
2025-07-30 6:01 ` [PATCH v2 2/9] Makefile: suppress Ansible warnings during configuration generation Luis Chamberlain
2025-07-30 6:22 ` Daniel Gomez
2025-07-30 6:01 ` [PATCH v2 3/9] playbooks: few space cleanups Luis Chamberlain
2025-07-30 6:01 ` [PATCH v2 4/9] style: add extensive code formatting checks to make style Luis Chamberlain
2025-07-30 6:01 ` Luis Chamberlain [this message]
2025-07-30 6:01 ` [PATCH v2 6/9] CLAUDE.md: add instrucitons to verify commit Luis Chamberlain
2025-07-30 6:01 ` [PATCH v2 7/9] all: run black Luis Chamberlain
2025-07-31 12:57 ` Daniel Gomez
2025-08-01 8:12 ` Daniel Gomez
2025-08-01 12:55 ` Chuck Lever
2025-08-01 16:29 ` Daniel Gomez
2025-08-01 16:55 ` Chuck Lever
2025-07-30 6:01 ` [PATCH v2 8/9] devconfig: add automatic APT mirror fallback for Debian testing Luis Chamberlain
2025-07-30 6:41 ` Daniel Gomez
2025-08-01 17:39 ` Luis Chamberlain
2025-07-30 6:01 ` [PATCH v2 9/9] bootlinux: add support for A/B kernel testing Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250730060147.182140-6-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=cel@kernel.org \
--cc=da.gomez@kruces.com \
--cc=kdevops@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox