From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0132C2D949D for ; Mon, 11 Aug 2025 20:12:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754943154; cv=none; b=Ju9cEJ1eP1bKBdzANCu8KKbU3Q8UGa9GomMywMo/iC3PBPw+Jao3Qsoaw8j759NO48+3DjlN4lishhCLbTguUbrx0TBX281J8Wm3X5jEEhhgJGu/hONa3dogm4KWitji0LxZiqn2PbfRFYCCPWROvKtJTUh9b71oNCsr4QyxgG4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754943154; c=relaxed/simple; bh=3sEbWzSNpJz8Pb2JN0H2UwrgOaI6PhdCLc1L1c8Ar5w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Uoot4kb6ss5qP3hNdDTmEwdnHnA9QwM4wrsNQh9KorxWYgdCJuZoz+O2XMeJ3rhf4zW4cNmN1VGm+5OijalFXjx0bpgmC7MIjVVrQ2fE5KqT1ixCT3hKgWN1CBJmYtcd4wPGJp0EYpKcAoXY/rZlW5Aawq97pU7ES9XrwRKLyIs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=3noSdmur; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="3noSdmur" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=9sNfKOX37QMO940+Iz5KXAjIlgZWSMeOHszPPxAdQRM=; b=3noSdmur0iPJB/+Vkishlj4KLX 57x7CFruq+2CHkzzZSW3MnNDw5k7fH3ImgYqhglOlvn9yEkUzwZtw5Znl5iZ+TuDsVP+UQCQ56U8x AEPIoWS7b82bdiNKRmq3ayOISdXFRO0Aj21iIJ4fr+8E7mTDlkvWWKC62r/xK82Z4BbNatllsaRgi Odz7UZUb+Ewwz6qhTSVV1s3NfkdW+rOH8B+d9Suu0h1N2a17kavcUk6ypXLjpmMeUQrrPJnbdx2s9 IPojtCXOd8gGZGb25/fSu1mAymPtnFaa44USC1WokyYMoU/xpLVgrXN9gMGM5lR0XuHpEVIyZ4dt6 1Z3F1D8w==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1ulYsh-0000000904N-2PV3; Mon, 11 Aug 2025 20:12:31 +0000 From: Luis Chamberlain To: Chuck Lever , Daniel Gomez , kdevops@lists.linux.dev Cc: Luis Chamberlain Subject: [PATCH 7/8] gen_nodes: fix YAML indentation in pcipassthrough template Date: Mon, 11 Aug 2025 13:12:29 -0700 Message-ID: <20250811201230.2145164-8-mcgrof@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250811201230.2145164-1-mcgrof@kernel.org> References: <20250811201230.2145164-1-mcgrof@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Luis Chamberlain The template was generating malformed YAML with improper indentation and missing newlines between passthrough entries. This caused parsing errors: "Colons in unquoted values must be followed by a non-space character." Fixed by: - Removing the trailing whitespace stripping after 'pcipassthrough:' - Ensuring proper indentation for all passthrough entries - Maintaining consistent whitespace control throughout the macro The generated YAML now correctly produces a single 'pcipassthrough' key with properly indented sub-entries for all devices. Generated-by: Claude AI Signed-off-by: Luis Chamberlain --- playbooks/roles/gen_nodes/templates/gen_nodes_list.j2 | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/playbooks/roles/gen_nodes/templates/gen_nodes_list.j2 b/playbooks/roles/gen_nodes/templates/gen_nodes_list.j2 index 6ad2af1..bb4e053 100644 --- a/playbooks/roles/gen_nodes/templates/gen_nodes_list.j2 +++ b/playbooks/roles/gen_nodes/templates/gen_nodes_list.j2 @@ -5,14 +5,13 @@ {%- if not ns.has_devices -%} {%- set ns.has_devices = true %} pcipassthrough: -{% endif -%} - passthrough{{ ns.device_index | string }}: +{% endif %} passthrough{{ ns.device_index | string }}: domain: {{ d.domain }} bus: {{ d.bus }} slot: {{ d.slot }} function: {{ d.function }} -{%- set ns.device_index = ns.device_index + 1 -%} -{%- endif %} +{% set ns.device_index = ns.device_index + 1 -%} +{%- endif -%} {%- endfor -%} {%- endmacro -%} {%- macro gen_pci_passthrough( device_list ) -%} -- 2.47.2