From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CEA52D97BA for ; Mon, 11 Aug 2025 20:12:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754943153; cv=none; b=Msp4taYdVEm6VZ8gE2b3ciICQqzJ7fR1PPTyiLRtVUOF89gYMSHpUy+7y5nVypx+RGFXAxpYihrJEFHuouDFFBiyO0FCuCf5ZQwWc7aFMgcQsW9bb0MIV7w+7yElDWp/NG148dpMrkpiIwHB8+8XS2v0y2SevZNlq+CNh1M9SV0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754943153; c=relaxed/simple; bh=0LeVA6vvZG3Yy4m3HoVrKmbHaTYIuPIXv3toNmsHWXI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c6TPfmnKeQk4hzcHBqX4mWFpj9vxWGQ/AwZu2vnFDfZSnYa0nTU271WqCYvA0i1AVnU6LopEa4Dx+NtPpQrl7UME1PS484uDsJarBDDEJNuMLyedc7/rW+GtqAMZgriBYmHlHTRpiUMeCpIK3pFzDo4H7H1IC3Ed9aBpOqrrUmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=KuehzMGY; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="KuehzMGY" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=CiOgUkKJ3MGBwJj5Oj99DBnfrZ57nB1eGJtkxIXmIeA=; b=KuehzMGY9YzkEnbRNVv0ue/9K8 anqXI/7xhvInTlhQoPtPjXy8erMZSSTTdy1Cyb0bOq6pJL9QpMhwpZ299mSnPlfTAZMTK1US4Ibp7 oj+xU/Pii2EYkWQKImu6gc6tkffs5NqJJNkw2wN00HXdSCiVHtQONDCuPCg+Z/znznCweO4uhDkJj RnQoxgjx1PCUfd60gM4shlpexOnebcYdXZW+HOux2FLia4X9zPDLpGPhF/1I4CYT5cndlDe6W3P6h LZLgeaMq6T+tFQct5zEEy6zyNshkpfCeTZzxdHwG+y0g+xpPL+TxUVasjDQB/wo1OmS3GOG+vlGoj PG/Kh+aA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1ulYsh-0000000904S-2lmE; Mon, 11 Aug 2025 20:12:31 +0000 From: Luis Chamberlain To: Chuck Lever , Daniel Gomez , kdevops@lists.linux.dev Cc: Luis Chamberlain Subject: [PATCH 8/8] guestfs: fix PCIe passthrough device attachment Date: Mon, 11 Aug 2025 13:12:30 -0700 Message-ID: <20250811201230.2145164-9-mcgrof@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250811201230.2145164-1-mcgrof@kernel.org> References: <20250811201230.2145164-1-mcgrof@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Luis Chamberlain The virsh attach-device command was receiving the entire file information dictionary instead of just the file path, causing: error: Failed to open file '{'path': '/path/to/file.xml', ...}' Fixed by using {{ item.path }} instead of {{ item }} to extract just the file path from the find results. Generated-by: Claude AI Signed-off-by: Luis Chamberlain --- playbooks/roles/guestfs/tasks/bringup/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/playbooks/roles/guestfs/tasks/bringup/main.yml b/playbooks/roles/guestfs/tasks/bringup/main.yml index af95c5d..deb0846 100644 --- a/playbooks/roles/guestfs/tasks/bringup/main.yml +++ b/playbooks/roles/guestfs/tasks/bringup/main.yml @@ -119,7 +119,7 @@ - "virsh" - "attach-device" - "{{ inventory_hostname }}" - - "{{ item }}" + - "{{ item.path }}" - "--config" loop: "{{ passthrough_devices.files }}" loop_control: -- 2.47.2